[$500] [Wave Collect] [Ideal Nav] Navigating back to Workspace List doesn't work

[hayata-suenaga]

Action Performed:

1. If you’re testing this on desktop browser, shrink the window size
2. Workspace List → choose a workspace → click the back button on browser or Android
3. Confirm that you're taken back to the Workspace Settings page of the previous workspace when you should be taken back to the Workspace List page

There was additional issue reported that is related to this isssue

Wrong animation when selecting a workspace

1. Make sure you're on a mobile phone or on a browser with a smaller width
2. Make sure that the test account has at least one workspace
3. Click on the Settings icon 🔧 on the bottom tab > Workspaces > Select a workspace
4. Confirm that the Workspace List page closes to the right when the new page should appear from the right.

video -> #33280 (comment)

Expected Result:

It should take you back to Workspace List page

Actual Result:

You're taken back to Workspace Settings page instead of the Workspace List page

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

video → #33280 (comment)

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0154caf623797588b3
• Upwork Job ID: 1753227077608316928
• Last Price Increase: 2024-02-29

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0154caf623797588b3

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[jeremy-croff]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We are not able to navigate back from the workspace settings page.

What is the root cause of that problem?

In this flow we are deeplinking to the workspace Initial route from the all-settings screen. In order for the back navigation to work we have to provide a deeplink back.

What changes do you think we should make in order to solve the problem?

To provide a deeplink back we can use the <HeaderWithBackButton /> component inside of

App/src/pages/workspace/WorkspaceInitialPage.js

Line 175 in d9fd412

<FullPageNotFoundView

with the prop: onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WORKSPACES)}

A nuance to consider is that we also have a back button being rendered on the not found state for this screen, so we'd have to only show the HeaderWithBackButton component if the existing local variable shouldShowNotFoundPage condition is false in this component.

What alternative solutions did you explore? (Optional)

[hayata-suenaga]

I apologize 🙇 An expert agency (SWM), who worked on the original PR that caused this regression, will work on this issue.

[jliexpensify]

Ah, thanks for clearing this up @hayata-suenaga - does @getusha need to be assigned then?

[hayata-suenaga]

We can keep @getusha as C+ for this issue. We need a C+ when the PR is ready 😄

[WojtekBoman]

Hi! Working on it :)

[melvin-bot]

@jliexpensify, @getusha, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[getusha]

@WojtekBoman will raise the PR.

[WojtekBoman]

This issue turned out to be a bit complicated to fix and it requires from us introducing bigger changes to the part of the navigation logic responsible for BottomTabNavigator so before I start fixing it, I'd like to ask you about the priority of this issue, because it may take some time and to fix it we need to handle storing multiple bottom tab navigators in the navigation state. I suggest to focus on other issues until we make a decision how to fix it :)

[hayata-suenaga]

I'm changing the priority to weekly until Wojciech is back

[melvin-bot]

@jliexpensify @WojtekBoman @getusha @hayata-suenaga this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

[melvin-bot]

Current assignee @getusha is eligible for the Internal assigner, not assigning anyone new.

[hayata-suenaga]

@WojtekBoman is going to work on this when they have time

[hayata-suenaga]

changing the priority to weekly

[WojtekBoman]

I think this issue will be resolved when we merge the PR with ideal-nav-v2. It modifies the logic responsible for navigating between these screens

[hayata-suenaga]

ah niceeee 👍 in that case, I'll add the reviewing label to this issue

[hayata-suenaga]

let's come back to this issue after the PR is merged to see if it fixes the problem

[hayata-suenaga]

@WojtekBoman Let me know if this issue is related

[jliexpensify]

OOO from 21st to 31st March, but will keep this assigned to me (should be nothing for B0 to do in this period).

[trjExpensify]

Ideal Nav v2 merged ages ago. We good to close here or what are the next steps?

[hayata-suenaga]

I double confirmed that the issue is no longer reproducible

RPReplay_Final1712620784.MP4

Thank you Tom for reminding me to close this issue 😄