-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-02-19] [Wave8] [Account Settings] Update the HeaderWithBackButton component to work well with the new design #35609
Comments
Triggered auto assignment to @sakluger ( |
Hey, I'm from SWM, and I will work on this. |
The PR is ready for review. Can someone from the design team have a look at the results to verify padding, sizes, etc.? |
Will take a look at the PR, cc @Expensify/design for visibility too. PR is here: #35564 |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-02-19. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment handled here #35571 |
Coming from tracking issue for this initiative.
Using the Figma final mocks, please update the
HeaderWithBackButton
component so it can be reused well in the new designFor help with anything unclear, please, post in wave8 room.
cc @trjExpensify @dannymcclain
The text was updated successfully, but these errors were encountered: