Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-19] [Wave8] [Account Settings] Update the HeaderWithBackButton component to work well with the new design #35609

Closed
mountiny opened this issue Feb 1, 2024 · 9 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Feb 1, 2024

Coming from tracking issue for this initiative.

Using the Figma final mocks, please update the HeaderWithBackButton component so it can be reused well in the new design

image

For help with anything unclear, please, post in wave8 room.

cc @trjExpensify @dannymcclain

@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels Feb 1, 2024
@mountiny mountiny self-assigned this Feb 1, 2024
Copy link

melvin-bot bot commented Feb 1, 2024

@kosmydel
Copy link
Contributor

kosmydel commented Feb 2, 2024

Hey, I'm from SWM, and I will work on this.

@kosmydel
Copy link
Contributor

kosmydel commented Feb 2, 2024

The PR is ready for review. Can someone from the design team have a look at the results to verify padding, sizes, etc.?

cc @trjExpensify, @shawnborton

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 2, 2024
@shawnborton
Copy link
Contributor

Will take a look at the PR, cc @Expensify/design for visibility too. PR is here: #35564

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 8, 2024
Copy link

melvin-bot bot commented Feb 9, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 12, 2024
@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Feb 12, 2024
@melvin-bot melvin-bot bot changed the title [Wave8] [Account Settings] Update the HeaderWithBackButton component to work well with the new design [HOLD for payment 2024-02-19] [Wave8] [Account Settings] Update the HeaderWithBackButton component to work well with the new design Feb 12, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 12, 2024
Copy link

melvin-bot bot commented Feb 12, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 12, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-19. 🎊

For reference, here are some details about the assignees on this issue:

  • @kosmydel does not require payment (Contractor)

Copy link

melvin-bot bot commented Feb 12, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@kosmydel] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@mountiny
Copy link
Contributor Author

Payment handled here #35571

@github-project-automation github-project-automation bot moved this from Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) to Done in [#whatsnext] Wave 08 - Collect Plan Admins Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

4 participants