[HOLD for payment 2024-04-05] [$1000] Chat - The keyboard is overlapping with the composer

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.33-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Open a chat
2. Open the native keyboard emoji picker

Expected Result:

It shouldn't overlap.

Actual Result:

The keyboard is overlapping with the composer.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014446080d93df8ee7
• Upwork Job ID: 1752288736160931840
• Last Price Increase: 2024-03-20
• Automatic offers:
• situchan | Reviewer | 0
• suneox | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014446080d93df8ee7

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[eeleuch]

This can be fixed using height: "100smv" on the big container of this page
https://css-tricks.com/the-large-small-and-dynamic-viewports/

[melvin-bot]

📣 @eeleuch! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[eeleuch]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01237276f354a158ce

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[situchan]

@eeleuch please read through our contributing guidelines. Thanks

[melvin-bot]

@mallenexpensify, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[situchan]

No proposals yet

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@mallenexpensify, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@mallenexpensify @situchan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@mallenexpensify, @situchan Still overdue 6 days?! Let's take care of this!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mallenexpensify]

Added to #vip-vsb project, waiting on proposals

[iwiznia]

The solution is only applied to iOS safari

Oh ok, did not see it in the code that's why I asked.

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[suneox]

@iwiznia Thank you for your offer, I'll create PR for this issue today.
And I'd like to confirm which selected solution on my proposal for #35403

[iwiznia]

hmmmm honestly not sure which one is best, @situchan what do you think?

[situchan]

I haven't tested that other issue yet considering that as next PR.
update popoverInnerContainer maxHeight style to 100% this solution looks good in theory.

Actually, I think we can fix in one PR as no conflict between solutions.

[suneox]

I haven't tested that other issue yet considering that as next PR. update popoverInnerContainer maxHeight style to 100% this solution looks good in theory.

Actually, I think we can fix in one PR as no conflict between solutions.

Hi @situchan The PR is ready to review with your suggestion

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• 35380 virtual viewport on report screen #38755

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment automatic offer (Contributor)
• @situchan requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sobitneupane]

#39061 is regression from this issue @situchan Can you please review #39209 PR.

[mallenexpensify]

Holding on payment due to the regression. @situchan is out so @sobitneupane will be reviewing the PR

[mallenexpensify]

Sobit, the PR hit production 6 days ago, are you due payment here? If so, is it $250 or $500? I think it's $500 cuz the price reduction went into April 4 and your comment above is from March 29.

[sobitneupane]

@mallenexpensify Yup. I also think It should be $500.

[mallenexpensify]

Contributor: @suneox paid $1000 via Upwork
Contributor+: @situchan paid $500 via Upwork (50% reduction due to regression)
Contributor+: @sobitneupane owed $500 via NewDot (PR review to fix regression cuz @situchan was OOO).

TestRail GH created - https://github.com/Expensify/Expensify/issues/389037

Gonna close, @situchan , when you're back from OOO, please finish the checklist. Thx