Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] BA - Bad performance of app after changing the company website to URL that ends with a dot #35124

Closed
1 of 6 tasks
lanitochka17 opened this issue Jan 25, 2024 · 37 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 25, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.31-2
Reproducible in staging?: Y
Reproducible in production?: No, unable to check prod
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-requisite: the account must be an Expensifail account and have created a Workspace

  1. Go to Settings > Workspaces > Select Workspace > Bank account
  2. Select add with Plaid and enter credentials
  3. On Company information page, fill out the form as usually until you fill the date
  4. Go back to Company website field and change it to something that ends with a dot, i.e.
    "https://www.applause.expensifail.co.com."/
  5. Try to keep filling the form, change the date

Expected Result:

The app should keep running as usual, allowing the user to continue filling out the form and submit

Actual Result:

The app has a slow behavior when trying to change date, and is not possible to submit the form

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6354098_1706149441598.Wbfx6580_1_.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01eb30b84358fd8f55
  • Upwork Job ID: 1758394448509222912
  • Last Price Increase: 2024-02-27
  • Automatic offers:
    • shubham1206agra | Reviewer | 0
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 25, 2024
Copy link

melvin-bot bot commented Jan 25, 2024

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@thienlnam
Copy link
Contributor

Interesting - though I imagine this is a regex thing so probably also happening on prod. Going to remove the blocker

@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 25, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 29, 2024
Copy link

melvin-bot bot commented Jan 30, 2024

@roryabraham Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Feb 1, 2024

@roryabraham Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Feb 5, 2024

@roryabraham 10 days overdue. Is anyone even seeing these? Hello?

@roryabraham roryabraham added Weekly KSv2 and removed Daily KSv2 labels Feb 6, 2024
@melvin-bot melvin-bot bot removed the Overdue label Feb 6, 2024
@roryabraham
Copy link
Contributor

@lanitochka17 requesting retest to see if this is still reproducible

@roryabraham roryabraham added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Feb 6, 2024
@lanitochka17
Copy link
Author

Issue reproducible on the build 1.4.38-0

Kayg5607.1.mp4

@melvin-bot melvin-bot bot added the Overdue label Feb 15, 2024
@roryabraham
Copy link
Contributor

Seems like this can be made external

@melvin-bot melvin-bot bot removed the Overdue label Feb 16, 2024
@roryabraham roryabraham added Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor labels Feb 16, 2024
@melvin-bot melvin-bot bot changed the title BA - Bad performance of app after changing the company website to URL that ends with a dot [$500] BA - Bad performance of app after changing the company website to URL that ends with a dot Feb 16, 2024
Copy link

melvin-bot bot commented Feb 16, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01eb30b84358fd8f55

Copy link

melvin-bot bot commented Feb 16, 2024

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Feb 22, 2024
Copy link

melvin-bot bot commented Feb 22, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

@binumarcodes
Copy link

binumarcodes commented Feb 22, 2024

Hi @binumarcodes. We have a proposal template here. Can you please use that for this and any other proposals on Help Wanted issues in this repo?

Sorry i didn't really get what you mean, do you need me to restate the cause and how we are to resolve it?

@melvin-bot melvin-bot bot added the Overdue label Feb 26, 2024
@roryabraham
Copy link
Contributor

happy to assign to you @shubham1206agra since you expressed interest

@roryabraham
Copy link
Contributor

@binumarcodes yes, that's right. we need proposals to use the template. If you're unsure what I mean, look through some of the issues in this repo; there are plenty of examples to follow.

@roryabraham
Copy link
Contributor

I'm moving this back to external

@roryabraham roryabraham added External Added to denote the issue can be worked on by a contributor and removed Internal Requires API changes or must be handled by Expensify staff labels Feb 27, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

@roryabraham
Copy link
Contributor

put out a call in #newdot-performance as well: https://expensify.slack.com/archives/C05LX9D6E07/p1709023485700669

Copy link

melvin-bot bot commented Feb 27, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@mvtglobally mvtglobally removed the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Feb 27, 2024
@mvtglobally
Copy link

Issue is reproducible during KI retests.

@gedu
Copy link
Contributor

gedu commented Feb 28, 2024

I am from Callstack - I can take a look at this

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 28, 2024
@roryabraham
Copy link
Contributor

thanks @gedu

Copy link

melvin-bot bot commented Feb 28, 2024

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@gedu
Copy link
Contributor

gedu commented Feb 28, 2024

@roryabraham I think this issue isn't valid. It is using the old bank flow. In the current one I can't add a '.' (dot) at the end because it isn't a valid URL and won't let me continue.

Screenshot 2024-02-28 at 16 53 10

@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2024
@gedu
Copy link
Contributor

gedu commented Mar 4, 2024

@roryabraham friendly ping

@melvin-bot melvin-bot bot removed the Overdue label Mar 4, 2024
@roryabraham
Copy link
Contributor

roryabraham commented Mar 6, 2024

great, I had seen mockups but didn't realize that the new bank account forms were already implemented. Closing this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

10 participants