[$500] Room - @expensify.sms suffix appears after invitation & disappears after opening user avatar

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.31-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to a room
2. Click on the room header > Members > Invite
3. Invite via phone number
4. Return to the main chat
5. Click on the phone number in the invite notification
6. Note that it shows @expensify.sms
7. Click on the avatar
8. Close the avatar

Expected Result:

@expensify.sms should remain (behavior on production)

Actual Result:

@expensify.sms suffix disappears after opening user avatar

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6353531_1706119428365.20240124_194713.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bcbbe2d08d76f86e
• Upwork Job ID: 1752445825076850688
• Last Price Increase: 2024-03-19
• Automatic offers:
• dukenv0307 | Contributor | 0

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[thienlnam]

Not sure if this was an intentional update or not. But doesn't seem to need to be a blocker

[melvin-bot]

@tylerkaraszewski Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bcbbe2d08d76f86e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room - @expensify.sms suffix appears after invitation & disappears after opening user avatar

What is the root cause of that problem?

Problem related with this PR #28999

The main problem with the issue is that we have the wrong condition here

App/src/pages/settings/Profile/ProfileAvatar.tsx

Line 29 in bc3137a

if (!ValidationUtils.isValidAccountRoute(Number(accountID)) ?? !!avatarURL) {

Since we are using a new operator ??, the second part of the condition is never checked as result we call openPublicProfilePage

App/src/pages/settings/Profile/ProfileAvatar.tsx

Lines 28 to 33 in bc3137a

	useEffect(() => {
	if (!ValidationUtils.isValidAccountRoute(Number(accountID)) ?? !!avatarURL) {
	return;
	}
	PersonalDetails.openPublicProfilePage(accountID);
	}, [accountID, avatarURL]);

What changes do you think we should make in order to solve the problem?

To fix this issue we can use || instead of ??

As result :

if (!ValidationUtils.isValidAccountRoute(Number(accountID)) || !!avatarURL) {

Or something similar

What alternative solutions did you explore? (Optional)

NA

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

@expensify.sms suffix disappears after opening user avatar

I think the Expected Result doesn't sound correct, the @expensify.sms is known internally only, the user doesn't know about it and it should never be displayed for the user to see. We have a removeSMSDomain method just for this purpose, and it's used everywhere.

Also in this issue if we refresh the page, we'll see that there'll be no @expensify.sms suffix, which is correct. So the expectation here should be that @expensify.sms should never show, before or after.

What is the root cause of that problem?

1. When we invite a new member by phone number, the displayName in the back-end response (of InviteToRoom) is incorrect. Let's say the phone number is +1 401-659-7742, the displayName in response's personalDetailList will be [email protected].

Then when opening the Avatar, it will trigger this (due to a bug in this line where ?? was used in correctly, it should be ||). And this will call the OpenPublicProfilePage endpoint, the back-end will return the correct displayName now (as the formatted phone number) and the @expensify.sms will disappear

2. In here, we're not passing the accountID as data of the icons, so even though the back-end returns correct data now, in the Tooltip when hovering over member avatar in Members list, it will still show @expensify.sms

What changes do you think we should make in order to solve the problem?

1. Fix the back-end so that the displayName in the back-end response of InviteToRoom is correct (just like the displayName when calling OpenPublicProfilePage, same logic)

Although this should fix the issue already, we should also change ?? to || here, because with ?? usage currently, the second part (!!avatarURL) will never be evaluated because the first part is always a boolean (not null/undefined)

2. Pass the accountID to the icons data here so this UserDetailsTooltip logic will work correctly.

id: accountID,

What alternative solutions did you explore? (Optional)

NA

[aimane-chnaif]

@tylerkaraszewski should we show @expensify.sms everywhere or not?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@tylerkaraszewski, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[tylerkaraszewski]

I think we should show it nowhere, these should always look like phone numbers.

[melvin-bot]

@tylerkaraszewski, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[aimane-chnaif]

I am going to be OOO soon. Please assign new C+

[dukenv0307]

@tylerkaraszewski I can take over here as C+

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dukenv0307]

@tylerkaraszewski This issue is not reproducible, but I found the related bug, it seems to be a BE bug

Screen.Recording.2024-03-21.at.15.00.27.mov

API InviteToRoom returns the wrong displayName (within country code). After going to profile page, API OpenPublicProfilePage is triggered and it returns the correct displayName

Screen.Recording.2024-03-21.at.15.02.10.mov

[tylerkaraszewski]

Discussion here about how to fix the backend issue: https://expensify.slack.com/archives/C03TQ48KC/p1711403191153639

[melvin-bot]

@tylerkaraszewski, @dukenv0307 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[tylerkaraszewski]

I'm making this weekly because it's like my 3rd priority right now.

[tylerkaraszewski]

I should be able to look into this this week.

[tylerkaraszewski]

I did not. Maybe next week.

[tylerkaraszewski]

This has been sitting for months. I am closing it.