Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-07] App CallStack Audit: Enable ProGuard to optimize APK Size #34222

Closed
hurali97 opened this issue Jan 10, 2024 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Weekly KSv2

Comments

@hurali97
Copy link
Contributor

hurali97 commented Jan 10, 2024

Description:

This is a part of implementation phase from Metric: APK Size in MB. The parent issue can be found here #33070.
The idea is to enable minification using ProGuard and remove unused resources.

@Julesssss -- also necessary for code obfuscation

Proposal

#33070 (comment)

@hurali97 hurali97 added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jan 10, 2024
Copy link

melvin-bot bot commented Jan 10, 2024

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@hurali97
Copy link
Contributor Author

@mountiny Can we assign this issue to me? I don't have rights to assign OR update the labels. Would be cool if you can also update the label to Task ?

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jan 10, 2024
@mountiny mountiny added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Jan 10, 2024
Copy link

melvin-bot bot commented Jan 10, 2024

Current assignee @slafortune is eligible for the NewFeature assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Jan 11, 2024

Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@Julesssss Julesssss assigned Julesssss and unassigned tgolen Jan 11, 2024
@Julesssss
Copy link
Contributor

@tgolen feel free to reassign, but I had already reviewed and tested this PR

Copy link

melvin-bot bot commented Jan 30, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 31, 2024
@melvin-bot melvin-bot bot changed the title App CallStack Audit: Enable ProGuard to optimize APK Size [HOLD for payment 2024-02-07] App CallStack Audit: Enable ProGuard to optimize APK Size Jan 31, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 31, 2024
Copy link

melvin-bot bot commented Jan 31, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

  • @hurali97 does not require payment (Contractor)

Copy link

melvin-bot bot commented Jan 31, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@hurali97] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Copy link

melvin-bot bot commented Feb 7, 2024

Payment Summary

Upwork Job

  • Contributor: @hurali97 is from an agency-contributor and not due payment
  • ROLE: @shubham1206agra paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@slafortune)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@slafortune
Copy link
Contributor

Contributor: @hurali97 is from an agency-contributor and not due payment
C+: @shubham1206agra paid $500 via Upwork (LINK) PD!

@melvin-bot melvin-bot bot removed the Overdue label Feb 7, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants