-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-02-07] App CallStack Audit: Enable ProGuard to optimize APK Size #34222
Comments
Triggered auto assignment to @slafortune ( |
@mountiny Can we assign this issue to me? I don't have rights to assign OR update the labels. Would be cool if you can also update the label to Task ? |
Current assignee @slafortune is eligible for the NewFeature assigner, not assigning anyone new. |
Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@tgolen feel free to reassign, but I had already reviewed and tested this PR |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-02-07. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment Summary
BugZero Checklist (@slafortune)
|
Contributor: @hurali97 is from an agency-contributor and not due payment |
Description:
This is a part of implementation phase from Metric: APK Size in MB. The parent issue can be found here #33070.
The idea is to enable minification using ProGuard and remove unused resources.
@Julesssss -- also necessary for code obfuscation
Proposal
#33070 (comment)
The text was updated successfully, but these errors were encountered: