Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distance - Cannot create distance expense with duplicate start/finish + duplicate stop #34209

Closed
6 tasks done
kavimuru opened this issue Jan 10, 2024 · 6 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.23-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

  1. Star a distance request.
  2. Input the same address for both the start and finish waypoints, e.g., "45 N Beach Rd, FL."
  3. Click on "Add Stop"
  4. Enter a different address, e.g., "Beach Access Path, Sunny Isles Beach, FL."
  5. Click on "Add Stop" once again
  6. Enter the same address as in step 4 to create two duplicate stops
  7. Click on ''Next''button

Expected Result:

User should be able to create a distance expense with a duplicate start/finish with a duplicate stop.

Actual Result:

Unable to create a distance expense with a duplicate start/finish + duplicate stop.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6337314_1704854363509.Distance_exp_-_ND_-staging.mp4

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 10, 2024
Copy link

melvin-bot bot commented Jan 10, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 10, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 10, 2024

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@thienlnam
Copy link
Contributor

I am not sure this is a bug - there are two duplicate stops that are right next to each other

@thienlnam
Copy link
Contributor

thienlnam commented Jan 10, 2024

Screenshot 2024-01-10 at 2 32 53 PM

Not being able to submit this seems expected - if you removed one of the middle stops it should work

@thienlnam
Copy link
Contributor

Verified this works as intended on staging

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants