Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] IOU - Split scan if merchant not entered, error not displayed #33884

Closed
3 of 6 tasks
kbecciv opened this issue Jan 3, 2024 · 6 comments
Closed
3 of 6 tasks

[$500] IOU - Split scan if merchant not entered, error not displayed #33884

kbecciv opened this issue Jan 3, 2024 · 6 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Jan 3, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.21
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Tap on fab --- Request money --- Scan
  3. Upload a photo
  4. Select 2 participants
  5. Select add to split
  6. Tap on split
  7. Tap on scan request created
  8. Enter an amount
  9. Tap split
  10. Tap on scan split created to open details page

Expected Result:

When user taps split without entering merchant details error message under merchant section should be displayed and user must not be allowed to create scan split request.

Actual Result:

When user taps split without entering merchant details, no error message under merchant section displayed and user allowed to create scan split request.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6331479_1704301087810.scansplit.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0141201e1b299de4ef
  • Upwork Job ID: 1742597879398060032
  • Last Price Increase: 2024-01-03
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 3, 2024
Copy link

melvin-bot bot commented Jan 3, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0141201e1b299de4ef

@melvin-bot melvin-bot bot changed the title IOU - Split scan if merchant not entered, error not displayed [$500] IOU - Split scan if merchant not entered, error not displayed Jan 3, 2024
Copy link

melvin-bot bot commented Jan 3, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 3, 2024
Copy link

melvin-bot bot commented Jan 3, 2024

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Jan 3, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@paultsimura
Copy link
Contributor

paultsimura commented Jan 3, 2024

As per #33786 (comment), the merchant is not required on the non-expense requests with receipts. So I'd say this is an expected behavior now.

@mountiny could you please confirm/correct?

@mountiny
Copy link
Contributor

mountiny commented Jan 4, 2024

Yep this is correct the merchant is not required for non-expense cases

@mountiny mountiny closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants