Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] IOU-App crashes when creating split bill in #announce & group chat #33802

Closed
1 of 6 tasks
izarutskaya opened this issue Dec 30, 2023 · 12 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@izarutskaya
Copy link

izarutskaya commented Dec 30, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.20-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

  1. Launch app / Go to https://staging.new.expensify.com/
  2. Tap on announce room
  3. Tap plus icon----Split bill
  4. Enter an amount and tap next
  5. Tap split
  6. Tap on split bill created to open split bill details page
  7. Note split bill button is displayed even after split bill created.
  8. Enter all fields
  9. Tap split bill
  10. Note tapping on split bill app crashes in Android and does not trigger any action in mweb.

Or

1.Launch app / Go to https://staging.new.expensify.com/
2.Tap fab
3. Tap start chat
4. Select few users and create group
5. Tap plus icon----Split bill
6. Enter an amount and tap next
7. Tap split
8. Tap on split bill created to open split bill details page
9. Note split bill button is displayed even after split bill created.
10. Enter all fields
11. Tap split bill
12. Note tapping on split bill app crashes in Android and does not trigger any action in mweb

Expected Result:

In split bill details page, split bill button must not be displayed after split bill is made.

Tapping on split bill, it must be created in mweb and Android without crash.

Actual Result:

In split bill details page, split bill button is displayed even after split bill is made.
Tapping on split bill app crashes in Android and does not trigger any action in mweb.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6329089_1703940213990.group_mweb.mp4
Bug6329089_1703940050759.Android_announ_cras.mp4
Bug6329089_1703939837442.announ.mp4
Bug6329089_1703938844440.ancea.mp4

Bug6329089_1703938965276!crash.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01274435e5bbe3d2d3
  • Upwork Job ID: 1741177178628956160
  • Last Price Increase: 2024-01-06
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 30, 2023
@melvin-bot melvin-bot bot changed the title IOU-App crashes when creating split bill in #announce & group chat [$500] IOU-App crashes when creating split bill in #announce & group chat Dec 30, 2023
Copy link

melvin-bot bot commented Dec 30, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01274435e5bbe3d2d3

Copy link

melvin-bot bot commented Dec 30, 2023

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 30, 2023
Copy link

melvin-bot bot commented Dec 30, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Dec 30, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 30, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 30, 2023

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@gijoe0295
Copy link
Contributor

Should be tackled in #33786.

@robertjchen
Copy link
Contributor

Thanks! Looks like that is in review now: #33786 (comment)

@s77rt
Copy link
Contributor

s77rt commented Jan 4, 2024

#33850 is now merged. Is this fixed?

cc @gijoe0295 if you can retest

@gijoe0295
Copy link
Contributor

Confirmed that it has been fixed. The split bill details is now read-only.

Screenshot 2024-01-05 at 00 27 32

@s77rt
Copy link
Contributor

s77rt commented Jan 4, 2024

@anmurali We are good to close this

Copy link

melvin-bot bot commented Jan 6, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jan 8, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants