Distance - App redirects to expense report when returning online after editing distance offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.17-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #33266

Action Performed:

Precondition: There are three addresses saved in Recent destinations

1. Create a distance request with address A and B as Start and Finish points respectively
2. Navigate to the details page of the distance request
3. Go offline
4. Click Distance > Add stop > Add address C > Save it
5. Click Distance > Address C (Finish point) > Edit it so that Finish point becomes address A too
6. Save the edit
7. Go online

Expected Result:

App will stay in distance request details page

Actual Result:

App redirects to expense report automatically

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6326377_1703618482455.bandicam_2023-12-26_23-57-29-307.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @bfitzexpensify

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tgolen]

I'll start investigating. It's possible it was caused by #33266 but I want to verify that.

[mountiny]

@neil-marcellini @allroundexperts @dukenv0307 This is linked to PR you have been involved in, it does seem though that this is already in production if I am not mistaken and given its edge case I would vote this is not a blocker. @tgolen let me know what you think?

[tgolen]

I reverted the changes from #33266 locally, and I had trouble reproducing the issue because there is a bug that the PR fixes where you can't save the request in offline mode (clicking the save button does nothing). So, I'm not so sure that PR caused the redirect issue.

I do agree with @mountiny that the redirect issue reported here is not bad enough to be a deploy blocker. Everything works, it's just you end up in a slightly different place and it's easy to go back to the details.

I'm removing the deploy blocker label and I think we should consider opening this bug up to contributors to find the cause of it.

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[paultsimura]

I believe this is the same issue as with the scan receipts flow: the transactionThreadReportID in the API response (in our case – CreateDistanceRequest) comes different from the one created optimistically. So when we come back online, and the CreateDistanceRequest API Response arrives, the opened expense details report no longer exists.

It should be fixed with #31411 (we are holding #32552 for the same reason).

[bfitzexpensify]

Thanks @paultsimura. Subscribed to #31411, will re-test this once that's done.

[tgolen]

This is still on hold since #31411 is not done.

[tgolen]

Still on hold

[tgolen]

Still on hold

[bfitzexpensify]

Still on hold for #31411 - looks like the PR is in the final review stretch

[bfitzexpensify]

Same status - the PR we're waiting on has had all comments resolved in the last 24 hours, so we're close to being able to retest here.

[bfitzexpensify]

Still waiting on #31411

[bfitzexpensify]

Asked in Slack for this to be retested now that the held issue is complete

[paultsimura]

@bfitzexpensify we might want to hold for #33114 as well — it fills the gaps the first PR missed

[bfitzexpensify]

Thanks for the heads-up @paultsimura, I'll get QA to pause on the retesting for the moment then.

[bfitzexpensify]

#33114 is live - getting QA to retest this.

[kavimuru]

@bfitzexpensify Issue is not reproducible by the tester.

20240315_221608.mp4

[bfitzexpensify]

Great! Let's close this one out then.