[HOLD for payment 2024-01-18] [Card Settings] 🐛 "Physical card number" row is showing when the user has not completed their shipping details yet

[kevinksullivan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.16-3
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]

Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C05DWUDHVK7/p1703261097098169

Action Performed:

1. Assigned >$0 expensify card limit to [email protected]
2. Logged in to [email protected] and navigated to settings

Expected Result:

Only a "virtual card number" row should be showing until a user activates their physical card

Actual Result:

The "Physical card number" row is already showing

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cecc6a59ed91a8f9
• Upwork Job ID: 1738617571260575744
• Last Price Increase: 2023-12-23

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[grgia]

The fix for this one is here

App/src/pages/settings/Wallet/ExpensifyCardPage.js

Line 260 in 9208c95

{!_.isEmpty(physicalCard) && (

We shouldn’t check if the object is empty, we should also check if the card is in the correct state - ACTIVE (3)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cecc6a59ed91a8f9

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

[mallenexpensify]

@grgia, @sobitneupane should this be internal or external?
I'm off the next week, so please move the issue along if possible without me (not that I'd really do much as BZ...)

[melvin-bot]

@mallenexpensify, @sobitneupane, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@mallenexpensify, @sobitneupane, @grgia Eep! 4 days overdue now. Issues have feelings too...

[sobitneupane]

I believe this can be resolved externally. But I am not sure if it can be tested externally.

[melvin-bot]

@mallenexpensify, @sobitneupane, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@mallenexpensify, @sobitneupane, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[grgia]

I can get a PR up for this one today

[melvin-bot]

@mallenexpensify @sobitneupane @grgia this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[grgia]

Working on PR

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @sobitneupane owed $500 via NewDot

BugZero Checklist (@mallenexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1738617571260575744/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[mallenexpensify]

Contributor+: @sobitneupane due $500 via NewDot.

@sobitneupane can you please propose regression test steps? Thx

[mallenexpensify]

@sobitneupane can you propose the regression steps plz?

[sobitneupane]

@mallenexpensify Sorry for the delay. I will be able to work on the checklist only in the weekend. I am working only 50% this week.

[melvin-bot]

@mallenexpensify, @sobitneupane, @grgia Eep! 4 days overdue now. Issues have feelings too...

[grgia]

not overdue, waiting on checklist / payments

[mallenexpensify]

@sobitneupane plz update the checklist.

[sobitneupane]

I will work on the checklist before weekend.

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#26915

• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#26915 (comment)

• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

It was a case missed while introducing a new feature.

• [@sobitneupane] Determine if we should create a regression test for this bug.

No.

[melvin-bot]

@mallenexpensify, @sobitneupane, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

@sobitneupane I feel like we should have a regression test for this, unless we're confident it won't ever happen again. @grgia , what do you think?

[sobitneupane]

I did the test by adding some data in onyx in local environment. I will need some help from @grgia to finalize the regression steps for QA.

Regression Test Proposal: (QA steps from PR)

1. In Old Dot: Assign >$0 expensify card limit to @expensifail.com account
2. In New Dot: Logged in to @expensifail.com account and navigated to settings
3. Go to Expensify Card Page /settings/wallet/card/expensify.com and verify that virtual card row is displayed, no physical card row is displayed, and button reads "Get physical card" ✅
4. Go through Get Physical Card Flow
5. After completion, ensure that physical card row is displayed ✅

Do we agree 👍 or 👎

[grgia]

@sobitneupane LGTM

[mallenexpensify]

Contributor+: @sobitneupane due $500 via Newdot.

Thanks! Testrail update GH is here https://github.com/Expensify/Expensify/issues/368473

[JmillsExpensify]

$500 approved for @sobitneupane based on summary above.