Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Money – Unexpected error appears when filling fields after scan failure #33313

Closed
6 tasks done
lanitochka17 opened this issue Dec 19, 2023 · 4 comments
Closed
6 tasks done
Assignees
Labels
Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 19, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.14-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in
  3. Start the Request money flow in a 1:1 conversation with a user you have access to
  4. Select the scan option and upload a picture that will fail the scan process
  5. Wait for the scan to fail
  6. Edit the missing fields Amount and Merchant

Expected Result:

The error is cleared after the fields are edited

Actual Result:

Unexpected error appears when filling fields after scan failure

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6320209_1703015523844.Unexpected_error_when_filling_fields_after_scan_failure.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 19, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 19, 2023

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@francoisl
Copy link
Contributor

I can repro, this appears to be a backend issue given the error message. It points out to something that was recently deployed to staging.

{
    "jsonCode": 0,
    "message": "User_Utils::isValidLength(): Argument #1 ($property) must be of type string, null given, called in \/git\/releases\/expensify.com\/f0f30fb\/lib\/TransactionAPI.php on line 678",
    "requestID": "8382cd6cecbafa5a-SJC",
    "onyxData": []
}

@francoisl francoisl added the Reviewing Has a PR in review label Dec 19, 2023
@francoisl
Copy link
Contributor

Backend fix was deployed to staging, this flow is working now.

Screen.Recording.2023-12-19.at.2.13.45.PM.mov

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants