[HOLD for payment 2023-12-29] [HOLD for payment 2023-12-28] Desktop - Sign In - Console error Uncaught (in promise) TypeError: Cannot read properties

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.14-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31303

Action Performed:

1. Sign Out
2. Kill the app
3. Open app
4. Sign In

Expected Result:

Console errors should not be displayed

Actual Result:

Console error displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6319675_1702994068266.Screen_Recording_2023-12-19_at_15.51.30.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcochavezf]

I haven't seen this yet, I will be afk for a couple of hours and check it out when I return.

[marcochavezf]

Ok I found the cause of the problem, creating a PR to fix it

[marcochavezf]

PR up

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[marcochavezf]

Hi @joekaufmanexpensify, could you pay for the C+ review for @allroundexperts?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Uncaught (in promise) TypeError in Timing.ts #33327

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests

[joekaufmanexpensify]

Per this, payment may be delayed a few days here because of the holidays. @allroundexperts if you have time over the next week to handle the BZ checklist too, that'd be great!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.15-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Uncaught (in promise) TypeError in Timing.ts #33327

If no regressions arise, payment will be issued on 2023-12-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR: dev: measure app start TTI more accurately #13997
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/13997/files#r1440680291
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[marcochavezf]

Not overdue, checklist is still pending

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @MitchExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

### Payment Summary
[Upwork Job]()
- Reviewer: @allroundexperts owed $500 via NewDot

#### BugZero Checklist (@MitchExpensify)
- [ ] I have verified the correct assignees and roles are listed above
- [ ] I have verified that there are no duplicate or incorrect contracts on Upwork (https://www.upwork.com/ab/applicants//hired)
- [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
- [ ] I have verified the payment summary above is correct

[MitchExpensify]

Not sure why I was assigned, looks like @joekaufmanexpensify is on the case

[joekaufmanexpensify]

Yep! Just need @allroundexperts to handle BZ checklist and then I'll issue payment.

[melvin-bot]

@marcochavezf, @allroundexperts, @joekaufmanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[joekaufmanexpensify]

Bumped in Slack

[joekaufmanexpensify]

Still discussing in Slack

[allroundexperts]

Checklist

1. dev: measure app start TTI more accurately #13997
2. https://github.com/Expensify/App/pull/13997/files#r1440680291
3. N/A
4. I think this is really small and regression test would be an overkill.

Do we 👍 or 👎 ?

[joekaufmanexpensify]

TY! Checklist is done. All set to issue payment.

[joekaufmanexpensify]

Only payment needed here is $500 to @allroundexperts for C+ review. Paid via NewDot.

[joekaufmanexpensify]

@allroundexperts could you please request $500 and comment here once you've done that?

[joekaufmanexpensify]

Chatted with @allroundexperts and confirmed good to close.

[JmillsExpensify]

$500 payment to @allroundexperts based on this comment.