Deploy Checklist: New Expensify 2023-12-19

[github-actions]

Release Version: 1.4.14-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Migrate Icon/index.js and FloatingActionButton to function component #26654
• Check if principal's email is public #29929
• [TS migration] Migrate 'PersonalDetailsUtils.js' lib to TypeScript #30169
• E2E chat opening #30634
• [No QA] Bust CloudFlare cache during HelpDot deploys #30877
• Fix/30190: Duplicate phone number can be invited to room #31010
• [TS migration] Migrate 'FormAlertWithSubmitButton.js' component to TypeScript #31303
• Feature: Use attachment gallery everywhere #31308
• [TS migration] Migrate 'ExceededCommentLength.js' component to TypeScript #31520
• [TS migration] Migrate 'AutoUpdateTime.js' component to TypeScript #31521
• Disable thread functions for whisper message #31676
• fix: treat certain US numbers as invalid #31726
• Clear notifications after opening a report #31762
• [TS migration] Migrate 'ValidateCode' component to TypeScript #31853
• [TS Migration] Migrate Composer to TypeScript #31912
• fix: Avatar changes when from offline to online #32090
• fixes keyboard popup regression #32133
• [Form Provider Refactor] WorkspaceRateAndUnitPage #32156
• Fix/31863: Don't allow member to edit task in room #32165
• [NoQA] [Wave8] Breadcrumbs #32221
• Fix - Workspace - Currencies do not load after transition from OldDot when other user logged in ND #31789 #32245
• Fix new user does not appear in start chat after request IOU #32330
• Personal bank account option is not present in Pay with Expensify menu #32423
• [Form Provider Refactor] RoomNameInput fixes #32432
• [Wave8] Search Input component #32439
• Ideal nav LHP #32473
• [TS migration] Migrate 'ReportActionItemTaskAction.js' component to TypeScript #32560
• [TS migration] Migrate 'ReportActionItemRenameAction.js' component to TypeScript #32574
• Fix/30448 Edit request option is present for paid message and error shows up when editing paid IOU #32631
• [TS migration] Migrate 'SingleOptionSelector.js' component to TypeScript #32660
• [TS Migration] Migrate ReportActionItemDate.js to TypeScript #32675
• [TS migration] Migrate 'ReportActionItemThread.js' component to TypeScript #32710
• [TS migration] Migrate 'DeeplinkWrapper' component to TypeScript #32728
• [TS migration] Migrate 'UserDetailsTooltip' component to TypeScript #32731
• [No QA][TS migration] Migrate 'Lottie' component to TypeScript #32791
• [TS migration] Migrate 'FormAlertWrapper.js' component to TypeScript #32798
• [TS Migration] Migrate CheckboxWithLabel.js component to TypeScript #32814
• Fix DatePicker not saving drafts #32815
• Update FinancalForce.md #32890
• Fix/31856: User is signed out #32897
• Wrap long emails of a Next Steps message  #32910
• Fix fail close account log the user out instead of showing the error message #32936
• fix: Login – show only input error if both are present #32944
• feat: add needed icon and new menu item #32947
• show 3 dots menu in expense report header #32961
• (perf) Debounce search in OptionList #32962
• [TS migration] Migrate 'UnlinkLogin' page to TypeScript #32966
• [TS migration] Migrate 'PinButton.js' component to TypeScript #32968
• [Snyk] Upgrade electron-log from 4.4.7 to 4.4.8 #32976
• Fix: change copy url => "copy" #33008
• Revert "Show child tags indented on the Tag list" #33012
• Add new helpsite article for our new Budgets feature #33033
• Fix red dot shown on LHN avatar after updating a workspace avatar #33039
• Fix/32123: Remove pending fields when saving waypoints #33043
• [No QA][TS migration] Update TS guidelines #33054
• Clear the next steps every time user takes some IOU action #33076
• Fix addresses containing empty states #33082
• [Snyk] Upgrade electron-log from 4.4.7 to 4.4.8 #33088
• Update Row Hover Color to Product300 and update Card / ReportPreview Hover Color #33097
• whitelisted budget notification action #33140
• Update expensify-common commit hash in package.json #33142
• [No QA] Fix file type typo #33167
• Update Referral-Program.md #33188
• Use transparent lottie animations #33189
• Fix status message page doesn't refocus after going back to it #33210
• Fix LHP animation on smaller screens #33218
• Revert "[TS migration] Migrate 'UserDetailsTooltip' component to TypeScript" #33261
• [CP Staging] Revert "(perf) Debounce search in OptionList" #33297
• [NoQA] Revert: Migrate Icon/index.js and FloatingActionButton to function component #33325
• Fix Uncaught (in promise) TypeError in Timing.ts #33327
• [CP Staging] Remove borderRadius from LHP & fix linkTo function #33359
• [CP-Staging] Enable reply in thread for iou whisper action #33364
• [CP Staging] Disable clearReportNotifications on Android #33386

Deploy Blockers:

• [$500] [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 - App is still in dark mode when device dark mode is off #33101
• [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] Connect Bank account - Inscription Additional beneficial owner is invisible on the page of beneficial owners #33135
• [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] Theme - "Join the discussion" is illegible and inconsistency in sign-in modal theme in public room #33159
• [$500] Android - App crashes , unable to open the app #33277
• [HOLD for payment 2024-01-03] Task - Assignee list opens after some delay #33282
• Sign In - "STG" label displayed on the right side against "Expensify" label on Sign In page #33283
• [HOLD for payment 2024-01-24] Settings - 'Go to Expensify Classic' options redirect to prod, not STG version #33284
• [HOLD for payment 2023-12-29] [HOLD for payment 2023-12-28] Desktop - Sign In - Console error Uncaught (in promise) TypeError: Cannot read properties #33290
• Web - App works with delay, when reinvite the member to WS #33291
• IOU - IOU report page displays 3 dots on top and user able to pin it #33292
• LHN - When user enters multiline message, first and last line displayed in LHN #33308
• [Theme Switching] 🐛 (Status Bar) iOS - Login - Time and wifi indicators are black in dark mode #33309
• [$500] IOS - App crashes after entering phone number 2nd or 3rd time in invite member flow #33311
• Request Money – Unexpected error appears when filling fields after scan failure #33313
• Chat - Message sender avatar is missing on applausetester+multiline account #33314
• Send Money - The participant selection page for Send money flow is noticeably slower #33322
• [HOLD for payment 2024-01-03] [HOLD for payment 2024-01-02] The new search component is slower and animation to open it isn’t smooth #33326
• [$500] Android - Attachment - A long image is severely compressed when added to a conversation. #33348
• [HOLD for payment 2023-12-29] [HOLD for payment 2023-12-28] Sign up - App crashes when signing up with a new account via magic link #33354
• [HOLD for payment 2023-12-29] [$500] Android - Attachment - Application crashes when trying to scroll PDF preview #33357
• [HOLD for payment 2023-12-29] [HOLD for payment 2023-12-28] Scan - "Reply in thread" is not present for IOU preview with ongoing smartscanning #33358
• [$500] [HOLD for payment 2023-12-29] [HOLD for payment 2023-12-28] Android - All message displayed instead of last 3 when switching to another chat #33367

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.14-0 🚀

[mvtglobally]

#32890 & #33033 PROD QA. Ok to check off?
#32731 is reverted, so we need to QA?

[jasperhuangg]

#32890 & #33033 PROD QA. Ok to check off?

yes!

#32731 is reverted, so we need to QA?

nope

@mvtglobally thanks for asking for confirmation

[Julesssss]

Checking off #33283 as its expected behaviour

[amyevans]

Checked off #33291 following revert of PR and retest

[mvtglobally]

@Julesssss @jasperhuangg we are blocked with Android at the moment. If you could prioritize that Blocker would be great

[francoisl]

Closing blocker #33313, backend fix was CP'ed to staging and confirmed working.

[jasperhuangg]

@mvtglobally We merged a revert of the offending PR that was causing the crash, I'll let you know as soon as it has been deployed to staging.

[jasperhuangg]

@mvtglobally can you update your Android builds and let me know if they're still crashing?

[mvtglobally]

@jasperhuangg asking

[mvtglobally]

Are we testing the build 1.4.14-1?

[jasperhuangg]

@mvtglobally we are testing [1.4.14-2](https://github.com/Expensify/App/tree/1.4.14-2), it seems like it's still building, sorry for the confusion

[jasperhuangg]

Checking off
#33101
#33135
#33159

Fixes were CP'd

[jasperhuangg]

Checking off #33284 NAB

[jasperhuangg]

@mvtglobally I think it should be deployed now, can you check if the crash still happens?

[Julesssss]

Checked off #33277 as the PR that introduced the issue has been reverted

[mvtglobally]

Regression is completed

OPen Blockers.
#33290
#33314
#33326
#33348
#33354
#33357
#33358
#33367

PRs
#31010 is failing #33301. Repro in PROD checking off
#31303 is failing #33290
#31762 is failing #33367
#32962 is failing #33322
#32966 is blocked with old KI #19915 on Desktop. but rest is pass. Are we good to check off?
#33359 Checking CP

[jasperhuangg]

Checking off #33290, CP'd a fix

[jasperhuangg]

Checking off #33314 NAB

[jasperhuangg]

Checking off #33348 NAB

[jasperhuangg]

Closing #33354, fix was CP'd

[jasperhuangg]

CP'd fix for #33358, checking off

[jasperhuangg]

Checking off #33367 CP'd fix

[jasperhuangg]

[os-botify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[melvin-bot]

📣 @os-botify[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[jasperhuangg]