-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Web - Hmm... it's not here page displayed after clicking on the card transaction preview #32155
Comments
Triggered auto assignment to @garrettmknight ( |
Job added to Upwork: https://www.upwork.com/jobs/~01da767971b05ba1f7 |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel ( |
Is there a way to create fake card transactions so I can try to reproduce this bug? |
📣 @junsupark94! 📣
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
@luacmartins do you happen to know who worked on adding cash transactions from OldDot to NewDot? It seems like we're fetching a bunch of cash transactions created outside of NewDot that never went through the money request flow. |
Current assignee @Santhosh-Sellavel is eligible for the Internal assigner, not assigning anyone new. |
Waiting for @luacmartins to answer the question above before figuring out who to loop in. |
Do you mean card transactions? From the OP this seems like a backwards compatibility issue, since it doesn't seem like we fetched those, we are manually navigating to a report we can only see in OldDot. As far as the migration for backwards compatibility goes, we deemed it out of the scope in the design doc so this is not done and expected, but maybe now is the time to do it?
|
@grgia do you think this is worth prioritizing now? |
@luacmartins but if the transaction exists in NewDot, then during the create transaction flow we should be creating the report in NewDot too shouldn't we? |
@garrettmknight TBD, I think if this pertains to old reports only, then no. But if it's a problem with our core transaction creation logic then yes- though we should try to do specific internal testing of this flow with real card transactions and reports before we work on this bug |
Yes, I read the OP wrong 😓 So the transactions do show up in NewDot but it seems like we have an issue opening the transaction thread. I couldn't reproduce the issue locally and the logs for reportID 2966681377842678 used in the video don't show any errors. @kavimuru could you please retest this and provide a video? |
@garrettmknight, @Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@luacmartins Sure will do! |
@luacmartins Retested and fixed now. Recording.5660.mp4 |
Cool, I think we're good to close this then. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Issue found when executing #31353
Version Number: 1.4.4-3
Reproducible in staging?: y
Reproducible in production?: not able to check
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:
Action Performed:
Pre-requisite: an account with the expensify card and transactions on that card
Expected Result:
The transaction preview is displayed
Actual Result:
Hmm... it's not here page displayed after clicking on the card transaction preview
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6293918_1701208556496.Recording__5571.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: