Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Web - Hmm... it's not here page displayed after clicking on the card transaction preview #32155

Closed
2 of 6 tasks
kavimuru opened this issue Nov 28, 2023 · 20 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@kavimuru
Copy link

kavimuru commented Nov 28, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing #31353
Version Number: 1.4.4-3
Reproducible in staging?: y
Reproducible in production?: not able to check
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Pre-requisite: an account with the expensify card and transactions on that card

  1. In OldDot, login into the account
  2. Navigate to the report that contains the Expensify card transactions
  3. Copy the reportID shown in the URL
  4. In NewDot, navigate to /r/ where reportID is the reportID copied in step 3
  5. Click on the card transaction preview

Expected Result:

The transaction preview is displayed

Actual Result:

Hmm... it's not here page displayed after clicking on the card transaction preview

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6293918_1701208556496.Recording__5571.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01da767971b05ba1f7
  • Upwork Job ID: 1729632742876860416
  • Last Price Increase: 2023-11-28
@kavimuru kavimuru added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 28, 2023
@melvin-bot melvin-bot bot changed the title Web - Hmm... it's not here page displayed after clicking on the card transaction preview [$500] Web - Hmm... it's not here page displayed after clicking on the card transaction preview Nov 28, 2023
Copy link

melvin-bot bot commented Nov 28, 2023

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Nov 28, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01da767971b05ba1f7

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 28, 2023
Copy link

melvin-bot bot commented Nov 28, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Nov 28, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

@junsuparkswe
Copy link

Is there a way to create fake card transactions so I can try to reproduce this bug?

Copy link

melvin-bot bot commented Nov 29, 2023

📣 @junsupark94! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@junsuparkswe
Copy link

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01f0918c3cf48c22cd

Copy link

melvin-bot bot commented Nov 29, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@grgia
Copy link
Contributor

grgia commented Nov 29, 2023

@luacmartins do you happen to know who worked on adding cash transactions from OldDot to NewDot? It seems like we're fetching a bunch of cash transactions created outside of NewDot that never went through the money request flow.

@grgia grgia added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Nov 29, 2023
Copy link

melvin-bot bot commented Nov 29, 2023

Current assignee @Santhosh-Sellavel is eligible for the Internal assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Overdue label Dec 1, 2023
@garrettmknight
Copy link
Contributor

Waiting for @luacmartins to answer the question above before figuring out who to loop in.

@melvin-bot melvin-bot bot removed the Overdue label Dec 1, 2023
@luacmartins
Copy link
Contributor

luacmartins commented Dec 1, 2023

Do you mean card transactions? From the OP this seems like a backwards compatibility issue, since it doesn't seem like we fetched those, we are manually navigating to a report we can only see in OldDot. As far as the migration for backwards compatibility goes, we deemed it out of the scope in the design doc so this is not done and expected, but maybe now is the time to do it?

We also have some backwards compatibility concerns here, since existing company card transactions don’t have a corresponding Workspace chat, ReportPreview action, IOU reportAction and existing company card transactions would need to be migrated. However, this was considered out of scope for Money 20/20 deadline and would be tackled as a phase 2 part of the project.

@melvin-bot melvin-bot bot added the Overdue label Dec 4, 2023
@garrettmknight
Copy link
Contributor

@grgia do you think this is worth prioritizing now?

@melvin-bot melvin-bot bot removed the Overdue label Dec 4, 2023
@grgia
Copy link
Contributor

grgia commented Dec 5, 2023

From the OP this seems like a backwards compatibility issue, since it doesn't seem like we fetched those, we are manually navigating to a report we can only see in OldDot.

@luacmartins but if the transaction exists in NewDot, then during the create transaction flow we should be creating the report in NewDot too shouldn't we?

@grgia
Copy link
Contributor

grgia commented Dec 5, 2023

@garrettmknight TBD, I think if this pertains to old reports only, then no. But if it's a problem with our core transaction creation logic then yes- though we should try to do specific internal testing of this flow with real card transactions and reports before we work on this bug

@luacmartins
Copy link
Contributor

luacmartins commented Dec 5, 2023

@luacmartins but if the transaction exists in NewDot, then during the create transaction flow we should be creating the report in NewDot too shouldn't we?

Yes, I read the OP wrong 😓 So the transactions do show up in NewDot but it seems like we have an issue opening the transaction thread. I couldn't reproduce the issue locally and the logs for reportID 2966681377842678 used in the video don't show any errors.

@kavimuru could you please retest this and provide a video?

@melvin-bot melvin-bot bot added the Overdue label Dec 7, 2023
Copy link

melvin-bot bot commented Dec 8, 2023

@garrettmknight, @Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@kavimuru
Copy link
Author

kavimuru commented Dec 8, 2023

@kavimuru could you please retest this and provide a video?

@luacmartins Sure will do!

@kavimuru
Copy link
Author

kavimuru commented Dec 8, 2023

@luacmartins Retested and fixed now.

Recording.5660.mp4

@luacmartins luacmartins self-assigned this Dec 8, 2023
@melvin-bot melvin-bot bot removed the Overdue label Dec 8, 2023
@luacmartins
Copy link
Contributor

Cool, I think we're good to close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

6 participants