Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [HOLD for payment 2023-12-20] [TS migration] Migrate '[Remaining Group 1]' lib to TypeScript #31920

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/getModalState.js 2
src/libs/NextStepUtils.js 2
src/libs/HeaderUtils.js 4
src/libs/DistanceRequestUtils.js 4
src/libs/shouldReopenOnfido/index.js 0
src/libs/shouldReopenOnfido/index.android.js 0
src/libs/migrations/RenameReceiptFilename.js 5
src/libs/migrations/KeyReportActionsDraftByReportActionID.js 4
src/libs/UpdateMultilineInputRange/index.js 0
src/libs/UpdateMultilineInputRange/index.ios.js 0
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01758752c83c0cecac
  • Upwork Job ID: 1742050869523697664
  • Last Price Increase: 2024-01-02
@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Dec 7, 2023
Copy link
Author

melvin-bot bot commented Dec 8, 2023

Triggered auto assignment to @robertjchen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 13, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate '[Remaining Group 1]' lib to TypeScript [HOLD for payment 2023-12-20] [TS migration] Migrate '[Remaining Group 1]' lib to TypeScript Dec 13, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 13, 2023
Copy link
Author

melvin-bot bot commented Dec 13, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Dec 13, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 19, 2023
@robertjchen
Copy link
Contributor

robertjchen commented Dec 20, 2023

I think we're done with this one, thanks!! 👍

@fedirjh
Copy link
Contributor

fedirjh commented Dec 28, 2023

cc @robertjchen I think this was closed without payment for the C+ review.

@robertjchen robertjchen reopened this Dec 30, 2023
@robertjchen robertjchen added the Bug Something is broken. Auto assigns a BugZero manager. label Dec 30, 2023
Copy link
Author

melvin-bot bot commented Dec 30, 2023

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link
Author

melvin-bot bot commented Dec 30, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@robertjchen
Copy link
Contributor

@sakluger Could you please help with the compensation for the C+ review here? Thanks!

@melvin-bot melvin-bot bot added the Overdue label Jan 1, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2024
@sakluger sakluger added External Added to denote the issue can be worked on by a contributor Overdue labels Jan 2, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-12-20] [TS migration] Migrate '[Remaining Group 1]' lib to TypeScript [$500] [HOLD for payment 2023-12-20] [TS migration] Migrate '[Remaining Group 1]' lib to TypeScript Jan 2, 2024
Copy link
Author

melvin-bot bot commented Jan 2, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01758752c83c0cecac

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 2, 2024
Copy link
Author

melvin-bot bot commented Jan 2, 2024

Current assignee @fedirjh is eligible for the External assigner, not assigning anyone new.

@sakluger sakluger changed the title [$500] [HOLD for payment 2023-12-20] [TS migration] Migrate '[Remaining Group 1]' lib to TypeScript [$250] [HOLD for payment 2023-12-20] [TS migration] Migrate '[Remaining Group 1]' lib to TypeScript Jan 2, 2024
Copy link
Author

melvin-bot bot commented Jan 2, 2024

Upwork job price has been updated to $250

@sakluger
Copy link
Contributor

sakluger commented Jan 2, 2024

Yep, I can help. @fedirjh I sent you an offer via Upwork for $250 (I believe that's the rate for typescript migration reviews). Let me know once you've accepted the offer and I can complete payment. Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2024
@fedirjh
Copy link
Contributor

fedirjh commented Jan 2, 2024

@sakluger Thank you. Accepted .

@sakluger
Copy link
Contributor

sakluger commented Jan 2, 2024

Thanks! All paid out 🙇

@sakluger sakluger closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

4 participants