[HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Expense - Bank account option is absent in Pay with Expensify dropdown

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.3.2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com.
2. Go to workspace chat > + > Request money.
3. Create a Manual request.
4. Click Pay with Expensify.

Expected Result:

Bank account option will be present.

Actual Result:

Bank account option is absent in Pay with Expensify dropdown.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6289530_1700832396306.bandicam_2023-11-24_09-34-27-510.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

📣 @github-actions[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account option is absent in Pay with Expensify dropdown

What is the root cause of that problem?

regression from #30582

App/src/components/AddPaymentMethodMenu.js

Lines 75 to 95 in 1e4c84b

	menuItems={[
	...(ReportUtils.isIOUReport(iouReport)
	? [
	{
	text: translate('common.personalBankAccount'),
	icon: Expensicons.Bank,
	onSelected: () => {
	onItemSelected(CONST.PAYMENT_METHODS.PERSONAL_BANK_ACCOUNT);
	},
	},
	]
	: []),
	...(!ReportActionsUtils.hasRequestFromCurrentAccount(lodashGet(iouReport, 'reportID', 0), lodashGet(session, 'accountID', 0))
	? [
	{
	text: translate('common.businessBankAccount'),
	icon: Expensicons.Building,
	onSelected: () => onItemSelected(CONST.PAYMENT_METHODS.BUSINESS_BANK_ACCOUNT),
	},
	]
	: []),

Before this PR, showed bank account menu always
After this PR, show bank account menu conditionally
So the issue is that if expense request (not IOU) and request from current account, it doesn't meet any conditions above

What changes do you think we should make in order to solve the problem?

We should fallback to original bank account selection logic
Here's pseudo code:

If IOU report, PERSONAL_BANK_ACCOUNT
If Expense report
    If !hasRequestFromCurrentAccount, BUSINESS_BANK_ACCOUNT
    Else PERSONAL_BANK_ACCOUNT

[luacmartins]

Put up a PR with a fix - #31858

[mountiny]

Made a new PR with different fix #31908 Carlos's PR would not work well with the desired bottom up flow.

[mountiny]

fixed

we can close this

Thankseveryone ans sorry for the regression, should have tested this case 🙇

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.3-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Show Business Bank account as payment option on expense reports #31908

If no regressions arise, payment will be issued on 2023-12-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Show Business Bank account as payment option on expense reports #31908

If no regressions arise, payment will be issued on 2023-12-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR