[HOLD for payment 2023-12-07] Tag - Child tags are not displayed in Recent

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.2-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

precondition: enable and add parent and child tags < 8 as an admin on OD

1. Log in to ND as an employee
2. Navigate to workspace chat
3. Tap the "+" > Request money
4. Enter the amount
5. On the confirmation screen, tap the "Show more" button
6. Tap "Tags" and select a child tag
7. Start another money request
8. Open "Tags" on the confirmation page

Expected Result:

Previously used child tag is displayed in Recent

Actual Result:

The previously used child tag is not displyed in Recent

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6287807_1700689610022.video_2023-11-22_16-41-09.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @JmillsExpensify

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

📣 @github-actions[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[lanitochka17]

Production:

video_2023-11-22_14-59-40.mp4

[bondydaa]

I'm suspicious of this PR #31494

[bondydaa]

precondition: enable and add parent and child tags < 8 as an admin on OD

Hmm I can't seem to figure out how to do this.

trying to click either of these workspaces I have just redirects me to new dot and I can't open up the policy editor in new dot

[bondydaa]

started a thread here https://expensify.slack.com/archives/C01GTK53T8Q/p1700694914941689

@lanitochka17 can you show me how to enable and create mutli-level tags on a workspace?

[luacmartins]

I'm gonna demote this to NAB since it's a pretty small issue. @bondydaa can you confirm if this PR is indeed the culprit and tag the original contributor to fix the issue?

[luacmartins]

I confirmed that reverting PR #31494 solves the issue. @FitseTLT can you work on a fix? cc @jjcoffee @roryabraham

[FitseTLT]

@luacmartins I will create a fix pr 👍 and will link it to this issue. Isn't that what I am supposed to do? @luacmartins

[jjcoffee]

@FitseTLT Yup, go ahead!

[FitseTLT]

@jjcoffee Pr ready 👍

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[bondydaa]

merged the PR. added BZ person to help with payments if needed, I'm not 100% sure on the process here since this was a regression from #31494.

[jjcoffee]

No payments will be due since it's a regression, as you say. I think we usually just close the issue once the fix hits production.

[JmillsExpensify]

Agreed, let's close once it hits production.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix:31760 recently used tags issue #31775

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment
• @FitseTLT requires payment

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[bondydaa]

closing this out as per last few comments.