Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy to clipboard is not limited per message #3134

Closed
isagoico opened this issue May 25, 2021 · 10 comments
Closed

Copy to clipboard is not limited per message #3134

isagoico opened this issue May 25, 2021 · 10 comments
Assignees
Labels
Daily KSv2

Comments

@isagoico
Copy link

isagoico commented May 25, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Expected Result:

Copy to clipboard should be limited to per message.

Actual Result:

Copy to clipboard is copying several messages

Action Performed:

  1. Navigate to a conversation
  2. Select several messages in a row
  3. Click on copy to clipboard in the action menu

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.43-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Grabando.183.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork


From @parasharrajat https://expensify.slack.com/archives/C01GTK53T8Q/p16208390261216007

When we select any text on message and press **Copy to Clipboard ** on context menu.
Selected text is not shown after menu open. No way user can know what is going to be copied full message or selected text.
You select the text and then move you cursor to different location and right click context menu will open at click location but copied text will be the selected text. In short, only copy selected text when context menu is opened over it.
You drag you cursor while clicking among messages, try to select text from multiple messages or Select the User name as well. Then Copy to Clipboard action copies everything that was selected. I think Copy to Clipboard was meant for per message only.

@isagoico isagoico added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label May 25, 2021
@MelvinBot

This comment has been minimized.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label May 25, 2021
@isagoico isagoico added the Daily KSv2 label May 25, 2021
@marcaaron marcaaron removed their assignment May 25, 2021
@marcaaron marcaaron added the External Added to denote the issue can be worked on by a contributor label May 25, 2021
@MelvinBot

This comment has been minimized.

@marcaaron
Copy link
Contributor

Actually, now I'm curious about this issue... Why should we not be able to copy multiple messages? What's wrong with that?

@marcaaron marcaaron removed the External Added to denote the issue can be worked on by a contributor label May 25, 2021
@marcaaron marcaaron added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label May 25, 2021
@MelvinBot
Copy link

Triggered auto assignment to @sophiepintoraetz (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label May 25, 2021
@parasharrajat
Copy link
Member

Actually, we were able to copy the UserName ,timestamp and anything that was selected etc. So I am not sure if that was desired.

@marcaaron
Copy link
Contributor

Any discussion about it or context to share? There's also this issue which seems to imply copying multiple comments should be allowed.

#1341

@parasharrajat
Copy link
Member

@BaraaSoft
Copy link

I would like to work on this issue.
My proposed solution is to disable other comments when user select a particular comment.
Doing so by maintaining the state of whether a specific comments is selectable. Utilising Text [selectable] prop.

@marcaaron
Copy link
Contributor

Link didn't work for me @parasharrajat can you summarize for us what was decided?

@marcaaron
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2
Projects
None yet
Development

No branches or pull requests

8 participants