-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-11-06] [HOLD for payment 2023-11-02] Request Money- Unable to cature image with camera button #30373
Comments
Triggered auto assignment to @NicMendonca ( |
Bug0 Triage Checklist (Main S/O)
|
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @amyevans ( |
ProposalProblemUnable to capture image with camera button Root Causeregression from #28813.
same issue ^ in asked for clarification on why this change was necessary. Changesoption 1. Remove this part and export NavigationAwareCamera directly option 2. remove forward Ref from here and use Same ^ change for |
@ishpaul777 it's intentional to use new |
Ah, I see that option 1 is what I suggested |
Thanks for the RCA @ishpaul777! @roryabraham do you have a preference whether we revert #28813, or cherry pick a fix? (Either from @ikevin127 if available, or @ishpaul777). cc @mananjadhav as well |
I am available to raise a quick PR |
Indeed I introduced this regression and I am creating a PR to fix it as we speak. |
Thanks! |
Created PR #30397 |
This should be resolved now. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.91-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-11-02. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.92-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-11-06. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
No need for any regression tests here. |
I think we still need to issue payment to @ikevin127 here |
Oh, whoops I spoke too soon, this was a regression so no separate payment should be issued for the fix |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.3.91-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
Image captured by tapping the green camera button
Actual Result:
Button non functional and Camera error message displayed on native apps
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
0-02-01-b3f64beb27581258ad1d8aab7b409ee9eece02cb69e5add22feb5e9e655ac438_aab450f0908ac7c.1.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: