Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awaiting payment][SMARTSCAN] LOW: Prevent uploading invalid files as receipts. #29960

Closed
Gonals opened this issue Oct 19, 2023 · 10 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff SmartScan Wave5-free-submitters

Comments

@Gonals
Copy link
Contributor

Gonals commented Oct 19, 2023

Problem
Currently, in the backend, we only allow certain filetypes as receipts:
$regFileTypes = '/(jpe?g|gif|png|pdf|html?|text|rtf|doc|tiff?|msword|zip|xml|message)/i';

We don't have any frontend checks for them.

Solution
Add those checks on the frontend for a better user experience

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015865ac74df1824c8
  • Upwork Job ID: 1714965684961083392
  • Last Price Increase: 2023-10-19
@Gonals Gonals added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Oct 19, 2023
@Gonals Gonals self-assigned this Oct 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~015865ac74df1824c8

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @situchan (Internal)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 19, 2023
@dylanexpensify dylanexpensify changed the title [Scan Receipt] [Polish] Prevent uploading invalid files as receipts. [SMARTSCAN] [Scan Receipt] [Polish] Prevent uploading invalid files as receipts. Nov 7, 2023
@dylanexpensify dylanexpensify changed the title [SMARTSCAN] [Scan Receipt] [Polish] Prevent uploading invalid files as receipts. [SMARTSCAN] [Scan Receipt] LOW: Prevent uploading invalid files as receipts. Nov 7, 2023
@dylanexpensify dylanexpensify changed the title [SMARTSCAN] [Scan Receipt] LOW: Prevent uploading invalid files as receipts. [SMARTSCAN] LOW: Prevent uploading invalid files as receipts. Nov 7, 2023
@dylanexpensify dylanexpensify added the SmartScan Wave5-free-submitters label Nov 7, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Nov 13, 2023
Copy link

melvin-bot bot commented Nov 13, 2023

This issue has not been updated in over 15 days. @Gonals, @kadiealexander, @situchan eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@Gonals
Copy link
Contributor Author

Gonals commented Nov 16, 2023

This has already been fixed. @kadiealexander, we just have payment left, right?

@situchan
Copy link
Contributor

The fix was deployed to production on Nov 9.
So today is due payment.
@Gonals can you please move to Daily and update issue title? Thanks

@Gonals Gonals added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Nov 16, 2023
@kadiealexander
Copy link
Contributor

kadiealexander commented Nov 22, 2023

Sorry team I was OOO. @situchan I've sent you an Upwork contract.

Payouts due:

Eligible for 50% #urgency bonus? No

Upwork job is here.

@kadiealexander kadiealexander removed the Reviewing Has a PR in review label Nov 22, 2023
@kadiealexander kadiealexander changed the title [SMARTSCAN] LOW: Prevent uploading invalid files as receipts. [Awaiting payment][SMARTSCAN] LOW: Prevent uploading invalid files as receipts. Nov 22, 2023
@AbdallaEmadEldinAbdalla

It can be easily done by checking the mimetype of selected file

Copy link

melvin-bot bot commented Nov 22, 2023

📣 @AbdallaEmadEldinAbdalla! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff SmartScan Wave5-free-submitters
Projects
No open projects
Development

No branches or pull requests

5 participants