Chat - Can't delete a message using the right click menu with Delete CTA unresponsive

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.86-4

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Issue found when executing PR #29844

Action Performed:

1. Launch new expensify
2. Go to any chat
3. Send a message
4. Right click on the message
5. Click on delete comment
6. Click on delete CTA

Expected Result:

The message is deleted

Actual Result:

Nothing happens when clicking delete on the pop up. The same CTA works if the delete icon was used on the hover menu

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6242303_1697665291215.Recording__430.mp4

MacOS: Desktop

Bug6242303_1697665291208.Recording__431.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[francoisl]

I can reproduce the issue on staging. I think we had another blocker related to deleting messages, going to check if it's coming from that.

[francoisl]

So far what I can tell is that reportIDRef.current on this line is 0. It's working fine on main though, so there might have been another PR merged recently that fixes this 👀

[francoisl]

I'm tempted to roll out the deploy with this bug considering that:

• we can't revert [CP Staging] Revert "Remove withNavigationFallback.js HOC" #29844, or it will reintroduce the crash from [HOLD for payment 2023-10-27] [HOLD for payment 2023-10-25] [$250] Chat - Deleting message in chat causes black screen #29839
• I can't reproduce the issue on main, so it should be fixed on the next staging version
• it only happens on desktop and web, and you can still delete a message by clicking the 🗑️ icon instead, so there's a straightforward workaround

Screen.Recording.2023-10-18.at.4.17.35.PM.mov

[francoisl]

This is fixed on staging and production now.