[HOLD for payment 2023-10-24] [$125] IOU - Expense preview card is wider than the Pay button

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.84-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Click + > Request money > Manual
4. Complete the request flow
   Note that the expense preview card is wider than the Pay button

Expected Result:

The expense preview card and the Pay button have similar width

Actual Result:

The expense preview card is wider than the Pay button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6237521_1697332502428.20231015_041509.mp4

Staging

Production

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019741438087b10f75
• Upwork Job ID: 1713665637747257344
• Last Price Increase: 2023-10-15
• Automatic offers:
• ntdiary | Reviewer | 27209686
• ishpaul777 | Contributor | 27209690
• situchan | Contributor | 27216588

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ishpaul777]

Proposal

Problem

Expense preview card is wider than the Pay button

Root Cause

We have applied the maxWidth of reportPreviewMaxWidth to the Pay button in MoneyReportView before it was sidebarWidth

offending PR #29431

Changes

We can safely remove the maxwidth from SettlementButton in MoneyReportView or change it back to sidebarWidth (or a new variable with same value)

<SettlementButton
   // rest of props
   style={[styles.mt3]}
/>

[ishpaul777]

I have reported this here https://expensify.slack.com/archives/C049HHMV9SM/p1697387154663989, @lanitochka17 can you check if i have reported this before Applause - Internal Team

[situchan]

@ishpaul777 you linked wrong PR. This is regression from #29431

[ishpaul777]

Thanks for that! @situchan, git blame sugested this as change added from #27660

[mountiny]

I will take this on. Thanks for the proposal @ishpaul777 Can you please raise a PR in the next 12 hours? Thanks!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019741438087b10f75

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[melvin-bot]

Upwork job price has been updated to $125

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fixes max width and pay button for report preview #29666

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment offer (Contributor)
• @situchan requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fixes max width and pay button for report preview #29666

If no regressions arise, payment will be issued on 2023-10-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment offer (Contributor)
• @situchan requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

No checklist required as this was a deploy blocker so the offending PR has been identified already, we do not need a regression test for this either

We need to pay $125 to @ishpaul777 and @situchan for this quick PR to resolve a deploy blocker I believe

[mallenexpensify]

@mountiny, @ishpaul777 and @situchan should also receive the urgency bonus, right?

[mountiny]

I guess yes, it was a deploy blocker so it had to be fixed fast

[mallenexpensify]

Issue reporter: Applause
Contributor: @ishpaul777 paid $200 via Upwork
Contributor+: @situchan paid $200 via Upwork

@situchan , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~019741438087b10f75

[situchan]

@mallenexpensify accepted, thanks

[mallenexpensify]

@situchan paid, updated the above payment breakdown.
Also... updated price above from $250 to $200, the correct amount.

Thanks y'all!

[sophiepintoraetz]

@mountiny, @ishpaul777 and @situchan should also receive the urgency bonus, right?

@mallenexpensify @mountiny - no, reviews are a flat fee no bonus applies here.

[mallenexpensify]

@sophiepintoraetz in post that was linked in the link you sent it says

The 50% urgency bonus will be remaining in place

I think deploy blockers are some of the most important bugs to fix in a timely manner so the urgency bonus makes sense. I'm unsure if we're thoroughly discussed or documented anywhere though.

[sophiepintoraetz]

Ah, I was coming from another issue which I think conflated some payment logic - my apologies! I agree we need to have a much simplified payment structure (we're doing away with urgency bonuses anyways, so kind of a moot point).