[HOLD for payment 2023-10-23] [$500] iOS - Screen flashes after selecting inputs while creating a Room

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #27836

Action Performed:

1. Log into HT account on Expensify app
2. While having at least 2 workspaces, selecting the FAB button
3. Select "send message" and select "room" tab
4. Begin inputting options in any form available on page eg "Who can post", "Visibility", etc

Expected Result:

User is able to input values without problems while creating room

Actual Result:

Screen begins to blink and flashes while options are selected

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.78-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6226301_1696529015014.RPReplay_Final1696524646.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010914cc66f062c549
• Upwork Job ID: 1710021385577029632
• Last Price Increase: 2023-10-05

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010914cc66f062c549

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[mountiny]

@dangrous I have tested a revert of this PR #27836 and it seems like this regression is resolved

It feels like the textares if stuck enlarging and shrinking or something

[abdel-h66]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Screen flicker when creating a room.

What is the root cause of that problem?

The issue comes from KeyboardAvoidingView used in the WorkspaceNewRoomPage, when the behavior is set to height, coming back from a select in the form, (workspace for example) will trigger the autofocus and brings up the keyboard on ios.

Note that this doesn't happen on android

Somehow, the height keeps being recalculated indefinitely until the keyboard is closed and then opened manually by focusing the text input.

What changes do you think we should make in order to solve the problem?

Changing the behavior property from height to padding seems to fix the issue

<KeyboardAvoidingView
   style={{height: '100%'}}
   behavior="padding"
   // Offset is needed as KeyboardAvoidingView in nested inside of TabNavigator instead of wrapping whole screen.
   // This is because when wrapping whole screen the screen was freezing when changing Tabs. 
   keyboardVerticalOffset={variables.contentHeaderHeight + variables.tabSelectorButtonHeight + 
   variables.tabSelectorButtonPadding + insets.top}
 > 

What alternative solutions did you explore? (Optional)

N/A

[situchan]

@abdel-h66 thanks for the proposal. We added KeyboardAvoidingView separately from ScreenWrapper in this commit to fix freeze issue on iOS.
Do you have better solution to remove this workaround and still use the benefit of keyboard avoiding behavior in ScreenWrapper?

[mountiny]

@abdel-h66 hey! we are going to use your solution in the PR so you will get paid 25% of the reward $125 for your proposal. Thank you for contributing ❤️

#29541

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Allow Welcome Message on Room Creation #29541

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @eVoloshchak does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Allow Welcome Message on Room Creation #29541

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @eVoloshchak does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

@kadiealexander no need for chekclist on this one, the originating PR is clear for the backlog here.

Only need to pay $125 to @abdel-h66 for their solution

[kadiealexander]

@abdel-h66 please apply here https://www.upwork.com/jobs/~010914cc66f062c549

[abdel-h66]

Done @kadiealexander thank you

[kadiealexander]

Sweet, contract sent!

[kadiealexander]

Paid!