[HOLD for payment 2023-10-25] Chat - Pasted text reflects Full Display name

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #27889

Action Performed:

1. Navigate to staging.new.expensify.com as User A
2. Request Money from User B
3. Sign in as User B
4. Go to IOU report
5. Click on 'Pay elsewhere' button
6. Click on 'copy to clipboard' icon
7. Paste the copied text

Expected Result:

The pasted text should reflect what was copied from the message

Actual Result:

Pasted text reflects copied message plus Full Display name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.75-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6219393_1696011506571.Recording__1098.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

N/A New Feature

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[abdel-h66]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU text message "Firstname paid elsewhere" does not match the copied text.

What is the root cause of that problem?

The copy action of the message Firstname paid elsewhere does not use the same logic as the preview.

In the preview we are getting only the short form of the payer name by passing true as second argument to getDisplayNameForParticipant

const payerName = isExpenseReport(report) ? getPolicyName(report) : getDisplayNameForParticipant(report.managerID, true);

In the copy to clipboard action, we are using almost the same logic but without the true flag

App/src/libs/ReportUtils.js

Line 3654 in 52f0e3c

const payerName = isExpenseReport(iouReport) ? getPolicyName(iouReport) : getDisplayNameForParticipant(iouReport.managerID);

What changes do you think we should make in order to solve the problem?

getIOUReportActionDisplayMessage responsible to generate the text to copy, is only called in a single place, we can just update the function call to include the short form flag.

What alternative solutions did you explore? (Optional)

N/A

[hoangzinh]

I think it's not a real deploy blocker. It's just a small inconsistency issue, users can still copy the IOU message (with a full display name).

If we can decrease the priority of this issue, I think we can have time to fix another potential inconsistency issue between displaying the IOU message and copying the IOU message.

• Displaying IOU message, we're using ReportUtils.getReportPreviewMessage util

  App/src/pages/home/report/ReportActionItemMessage.js

  Lines 41 to 48 in 52f0e3c

  	const isIOUReport = ReportActionsUtils.isMoneyRequestAction(props.action);
  	let iouMessage;
  	if (isIOUReport) {
  	const iouReportID = lodashGet(props.action, 'originalMessage.IOUReportID');
  	if (iouReportID) {
  	iouMessage = ReportUtils.getReportPreviewMessage(ReportUtils.getReport(iouReportID), props.action);
  	}
  	}

• Copying IOU message, we're using ReportUtils.getIOUReportActionDisplayMessage util

  App/src/pages/home/report/ContextMenu/ContextMenuActions.js

  Lines 202 to 203 in 52f0e3c

  	} else if (ReportActionsUtils.isMoneyRequestAction(reportAction)) {
  	const displayMessage = ReportUtils.getIOUReportActionDisplayMessage(reportAction);

• LHN

  App/src/libs/OptionsListUtils.js

  Lines 392 to 393 in 52f0e3c

  	} else if (ReportActionUtils.isMoneyRequestAction(lastReportAction)) {
  	lastMessageTextFromReport = ReportUtils.getReportPreviewMessage(report, lastReportAction, true);

[mountiny]

I can take this one over as I have been assigned to the original PR

I agree this is not a blocker, its a new feature and minor issue.

I think we should use the same methods for when we want the exact same message to be copied @rayane-djouah this is it feels like incompleteness from our PR, can you work on this as a follow up so the copied text exactly copies what the system message says?

[rayane-djouah]

I will raise a PR for this today.

[mountiny]

To confirm, this would be a continuation of the previous upwork job as we should make sure to get this right

[rayane-djouah]

PR ready for review

[mananjadhav]

To confirm, this would be a continuation of the previous upwork job as we should make sure to get this right

@mountiny Does this need review here?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Chat - Pasted text reflects Full Display name  #28561

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests)
• @rayane-djouah requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@peterdbarkerUK] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mananjadhav]

No payout for me here, I didn't review this. Unassigning myself.

[mountiny]

This was already paid and this was a regression handled from here #27114