-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread - In offline mode, clicking on reply thread directs to page keeps on loading #27712
Comments
Triggered auto assignment to @johncschuster ( |
Bug0 Triage Checklist (Main S/O)
|
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @tylerkaraszewski ( |
So even though the user left the thread. Once they click on the thread again they should be able to get access to it. So while offline showing Page not found is not correct when the user wants to join a thread IMO. The functionality should be the same as clicking into a new thread when offline which currently shows the report loader. So in this issue, if on staging we're showing a report loader then IMO that's good and consistent with regular threads so closing out this deploy blocker. If i have misunderstood anything feel free to correct me. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Issue found when executing PR #26602
Action Performed:
Expected Result:
In offline, tapping on reply thread must direct to not found page
Actual Result:
In offline, tapping on reply thread directs to page which keeps on loading showing "U" profile icon on header
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.71-5
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6205317_threadmweb26602.mp4
Bug6205317_26602.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: