[HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] Web - Money request preview box doesn't have any space with user title

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Request money from any user
2. Click on that report preview to navigate IOU report
3. Observe the space between user name and request preview box

Expected Result:

There should be space between the box and title

Actual Result:

There isn't any space between the box and title

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.71.4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-18.at.20.14.27.mov

Recording.4567.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Pujan92
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695048533117929

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Pujan92]

@getusha Seems regression from your PR where styles.moneyRequestPreviewBox applied before margin top.

[bondydaa]

looks like a fix is in the works already right? #27692

[getusha]

@bondydaa yes raised the PR since it was a regression from #27465

[bondydaa]

looks PR was merged #27465. and deployed to staging

can we confirm on staging this is fixed and closed if so @kbecciv ?

[fedirjh]

looks PR was merged #27465. and deployed to staging

cc @bondydaa That PR #27465 caused this blocker.

[getusha]

@bondydaa the PR fixing this issue is #27692

[fedirjh]

@getusha I guess you meant #27692

[getusha]

@getusha I guess you meant #27692

Oh yes! apologies 😄

[bondydaa]

Oh doh 🤦 thank you, reviewing the fix PR #27692 now

[bondydaa]

requested CP here https://expensify.slack.com/archives/C07J32337/p1695145933456359

[mountiny]

Thanks for a quick progress here https://expensify.slack.com/archives/C07J32337/p1695145933456359 we decided not to CP right now as we already got bunch of CPs we need for the deploy and this seems like an issue which can go through the normal process

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix report preview from being clickable on empty space #27465

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[kbecciv]

Issue is not reproduced on build 1.3.72.6 @bondydaa

Recording.4648.mp4

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix missing margin between name and request money preview box #27692

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

@bondydaa Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@bondydaa Still overdue 6 days?! Let's take care of this!

[bondydaa]

closing as this was a fix to a regression so no payment needed