[HOLD for payment 2023-10-09] [$500] Web - App closes RHN directly when we open 'Send message' using CTRL+SHIFT+K and back

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings
3. Open search using CTRL+K/CMD+K
4. Click back, it comes back to settings page
5. Open 'Send message' by CTRL+SHIFT+K
6. Click back and observe that it closes RHN instead of coming back to settings page

Expected Result:

App should not directly close RHN when we open any page, open Send message by CTRL+SHIFT+K shortcut and go back

Actual Result:

App directly closes RHN when we open any page, open Send message by CTRL+SHIFT+K shortcut and go back

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.71.4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

back.closes.RHN.using.send.message.mp4

Recording.4554.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695033497745239

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01afcf31288891f8d0
• Upwork Job ID: 1704074354945183744
• Last Price Increase: 2023-09-19
• Automatic offers:
• Pluto0104 | Contributor | 26854267
• dhanashree-sawant | Reporter | 26854269

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Pluto0104]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The problem we are addressing is that the Right Hand Navigation (RHN) is closing when we open the 'Send message' dialog using the keyboard shortcut CTRL+SHIFT+K and then navigate back.

What is the root cause of that problem?

The root cause of this issue is identified as a regression introduced in the 446f29b. The specific code snippet responsible for this behavior is found in NewChatSelectorPage.js, where Navigation.dismissModal is used to close the RHN.

App/src/pages/NewChatSelectorPage.js

Line 36 in 06e8d3a

onBackButtonPress={Navigation.dismissModal}

What changes do you think we should make in order to solve the problem?

To address this issue, we propose using the Navigation.goBack function instead of Navigation.dismissModal. Alternatively, we can consider removing this line altogether, allowing the onBackButtonPress function to revert to its default behavior of using Navigation.goBack.

What alternative solutions did you explore? (Optional)

N/A

Result

27669.mp4

[nkuoch]

Removing deploy blocker as think I kind of like this "regression".

I feel like if a user starts using Ctrl+K or Ctrl+shift+K, it means that they were done with whatever they were doing on the right side, and it makes sense to me that it "replaces the RHN" rather than "go over it".
So when clicking on the left arrow, I kind of like that it doesn't have to go through the previously opened RHN again.

Either way, poor ROI or limited user impact, so closing.

[dhanashree-sawant]

Hi @nkuoch, if we decide closing RHN is correct, shouldn't it be also done for CTRL+K?

[nkuoch]

All right, makes sense to make it consistent.
Let's just stick with going back rather than closing the modal then.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01afcf31288891f8d0

[melvin-bot]

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[ishpaul777]

Proposal

Problem

App closes RHN directly when we open 'Send message' using CTRL+SHIFT+K and back

Root Cause

We are explicitly passing a onBackButtonPress to dismiss modal when back button is pressed and on Searchpage we are not passing a method so it fallback to default Navigation.goBack()

Changes

Let's just stick with going back rather than closing the modal then.

To make behaviour consistent we can omit passing onBackButtonPress in New Chat page header so that it will also fallback to Navigation.goBack()

[ishpaul777]

@Pluto0104 not sure why you 👎 my proposal. am i missing something?

[Pluto0104]

Haha 😆 , sorry. I didn't see this:

Let's just stick with going back rather than closing the modal then.

But I think your proposal is the same as my first proposal.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fixed inconsistent back button behavior of NewChatSelectorPage #28138

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @robertKozik does not require payment (Contractor)
• @Pluto0104 requires payment offer (Contributor)
• @dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[dylanexpensify]

Payment summary:

• Reporter: @dhanashree-sawant $50
• Contributor: @Pluto0104 $750

[dylanexpensify]

@robertKozik mind completing checklist? 🙇‍♂️ @Pluto0104 is your Upwork profile not working?

[Pluto0104]

@dylanexpensify, I'm experiencing some issues with my Upwork profile. If you don't mind, could you make the payment to another Upwork profile instead?

[dylanexpensify]

@Pluto0104 we cannot, apologies!

[Pluto0104]

Hey @dylanexpensify, are you saying you won't cover the cost for that?

[dylanexpensify]

@Pluto0104 we can only make payments to your own Upwork account. If you need time to sort out your account, please do, and ping us when it's back on!

[Pluto0104]

@dylanexpensify, I've reached out multiple times, but my account has been permanently suspended.

[dylanexpensify]

discussing internally, one moment! 🙇‍♂️

[robertKozik]

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: There was no particular PR inttroducing this - it was not a bug, but inconsistency between the behaviours
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@robertKozik] Determine if we should create a regression test for this bug. I don`t think we should create the regression test for it
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[dylanexpensify]

Finishing this up today!

[melvin-bot]

@nkuoch, @dylanexpensify, @robertKozik, @Pluto0104 Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@nkuoch, @dylanexpensify, @robertKozik, @Pluto0104 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@nkuoch, @dylanexpensify, @robertKozik, @Pluto0104 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!