[HOLD for payment 2023-09-29] [$500] Request money - Scan - When the receipt scan fails, the requested user is prompted to "Enter an amount."

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1- Using userA Request money -> scan random image
2- select UserB
3- wait till the scan fails
4- Login to UserB
5- click on the requested money from user A

Expected Result:

"Enter an amount." should not be prompted to userB

Actual Result:

"Enter an amount." is prompted to userB

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.69-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Enter-Amount.mp4

Recording.6223.mp4

Expensify/Expensify Issue URL:

Issue reported by: @hichamcc

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693996797234579

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ba12fc29f8de1dec
• Upwork Job ID: 1701928878419435520
• Last Price Increase: 2023-09-13

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the receipt scan fails, the requested user is prompted to "Enter an amount."

What is the root cause of that problem?

we show the error for all user regardless of user can edit the request or not.

What changes do you think we should make in order to solve the problem?

we need to show the error based on both canEdit and hasErrors
by edit it once here or where hasErrors is used.

App/src/components/ReportActionItem/MoneyRequestView.js

Line 92 in 6b1a667

hasErrors = TransactionUtils.hasMissingSmartscanFields(transaction);

What alternative solutions did you explore? (Optional)

we can keep the error visible for the requested user and conditionally change the format of it, eg: failed to scan amont!

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ba12fc29f8de1dec

[melvin-bot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[mallenexpensify]

Was able to reproduce, Hoping/assuming it can be external, @allroundexperts can you review the proposals above plz?

[allroundexperts]

Thanks for your proposal @paultsimura. Unfortunately, I couldn't find any significant difference in your proposal when compared to @ahmedGaber93's proposal.

@ahmedGaber93's proposal looks good.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[paultsimura]

Thanks for your proposal @paultsimura. Unfortunately, I couldn't find any significant difference in your proposal when compared to @ahmedGaber93's proposal.

@ahmedGaber93's proposal looks good.

🎀 👀 🎀 C+ reviewed

I didn't notice that proposal, my bad. Indeed, they look identical. Good job @ahmedGaber93 💪

[melvin-bot]

@marcochavezf, @mallenexpensify, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!

[marcochavezf]

Assigning @ahmedGaber93 🚀

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

❌ There was an error making the offer to @ahmedGaber93 for the Contributor role. The BZ member will need to manually hire the contributor. cc @thienlnam

[melvin-bot]

📣 @hichamcc We're missing your Upwork ID to automatically send you an offer for the Reporter role.
Once you apply to the Upwork job, your Upwork ID will be stored and you will be automatically hired for future jobs!

[ahmedGaber93]

@allroundexperts PR is now ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix issue 27333 #27727

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)
• @ahmedGaber93 requires payment
• @hichamcc requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mallenexpensify]

@hichamcc , @ahmedGaber93 can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01ba12fc29f8de1dec

@allroundexperts , please complete checklist above

[hichamcc]

@mallenexpensify done

[mallenexpensify]

Issue reporter: @hichamcc paid $50 via Upwork
Contributor: @ahmedGaber93 paid $750 via Upwork, includes 50% urgency bonus
Contributor+: @allroundexperts due $750 via NewDot.

@allroundexperts , please complete the BZ checklist above

[ahmedGaber93]

@mallenexpensify I received only $500 not $750, can you please check this?

[allroundexperts]

Checklist

1. Display Smartscan errors #26155
2. https://github.com/Expensify/App/pull/26155/files#r1343279968
3. This was an edge case that could have been caught by better testing only. I don't think that a Slack discussion is needed here.
4. A regression test would be helpful here.

Regression Test Steps

1. Login as User A and request money from User B by scanning random image
2. Wait till the scan fails
3. Login to User B and click on the IOU request from User A

Verify that Enter an amount error is prompted to User A but not to User B.

Do we 👍 or 👎 ?

[mallenexpensify]

@ahmedGaber93 , I'm sorry, not sure how I messed that up, I just bonused you $250.
Thanks @allroundexperts for the test steps, GH created https://github.com/Expensify/Expensify/issues/323141

[JmillsExpensify]

$750 payment approved for @allroundexperts based on BZ summary.