[$1000] Settings - Help - Not auto focusing on search field for Help page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Login and then open Settings.
2. Open help.
3. Tap on search icon.

Expected Result:

When user tap on search icon it opens search tab but not focusing on Search field, keyboard should open on android/ios devices.

Actual Result:

When user tap on search icon ,Search field should be focused, keyboard should open on android/ios devices.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.67.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-capture.4.webm

Recording.4383.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Harshizonnet
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694070713281919

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01884263b0de13d0a5
• Upwork Job ID: 1701248465382961152
• Last Price Increase: 2023-11-01
• Automatic offers:
• aimane-chnaif | Reviewer | 27657496
• getusha | Contributor | 27657498
• Harshizonnet | Reporter | 27657499

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01884263b0de13d0a5

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @maddylewis (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[getusha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search field not auto focused when opening side bar on help page

What is the root cause of that problem?

In

App/docs/assets/js/main.js

Lines 102 to 116 in 1ae51cc

	function openSidebar() {
	document.getElementById('sidebar-layer').style.display = 'block';
	// Make body unscrollable
	const yAxis = document.documentElement.style.getPropertyValue('y-axis');
	const body = document.body;
	body.style.position = 'fixed';
	body.style.top = `-${yAxis}`;
	// Close the sidebar when clicking sidebar layer (outside the sidebar search)
	const sidebarLayer = document.getElementById('sidebar-layer');
	if (sidebarLayer) {
	sidebarLayer.addEventListener('click', closeSidebarOnClickOutside);
	}
	}

We are not focusing the search field when we open the sidebar, inside openSidebar function.

What changes do you think we should make in order to solve the problem?

We should select the search field using it's id which is gsc-i-id1 and focus the input programmatically when openSidebar function is triggered, using:

document.getElementById('gsc-i-id1').focus()

We will just add it here

@@ -108,6 +108,8 @@ function openSidebar() {
     body.style.position = 'fixed';
     body.style.top = `-${yAxis}`;
+    document.getElementById('gsc-i-id1').focus();

Result

Screen.Recording.2023-09-11.at.6.07.47.PM.mov

### What alternative solutions did you explore? (Optional)

[maddylewis]

melvin double assigned. im unassigning myself since i was the second assignee!!

[melvin-bot]

@anmurali, @aimane-chnaif Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@anmurali, @aimane-chnaif Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@anmurali @aimane-chnaif this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@anmurali, @aimane-chnaif 10 days overdue. Is anyone even seeing these? Hello?

[anmurali]

This is worth fixing!

[anmurali]

@aimane-chnaif can you pls review those proposals posted?

[melvin-bot]

@anmurali @aimane-chnaif this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

📣 @getusha 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @Harshizonnet 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[rushatgabhane]

Posting here too

Hi, I noticed the same code twice.

Could we please revert the changes in #31039
My PR to fix this was merged before #31039.

Also, this is a part of helpdot project. (no seperate issue based pay here)

App/docs/assets/js/main.js

Lines 104 to 112 in 2c7062b

	document.getElementById('gsc-i-id1').focus();
	// Make body unscrollable
	const yAxis = document.documentElement.style.getPropertyValue('y-axis');
	const body = document.body;
	body.style.position = 'fixed';
	body.style.top = `-${yAxis}`;
	document.getElementById('gsc-i-id1').focus();

[aimane-chnaif]

If so, this should have been closed earlier before contributors putting efforts on it.
This was open 2 months ago.
As this is triage issue, still apply full payment as contributor assigned, raised & merged PR. Revert doesn't matter as long as it's not because of regression.

[rushatgabhane]

Yeah that sounds fair!

To move things forward, @getusha could you please confirm if you'll be creating a revert PR 🙇
When resolving conflicts, I think we should look at time of merge.

[rushatgabhane]

duplicate issues and effort happen in a large project. i hope you understand :)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: auto focus input when opening RHN #31039

If no regressions arise, payment will be issued on 2023-11-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @getusha requires payment offer (Contributor)
• @aimane-chnaif requires payment offer (Reviewer)
• @Harshizonnet requires payment offer (Reporter)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha / @aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@getusha / @aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@getusha / @aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@getusha / @aimane-chnaif] Determine if we should create a regression test for this bug.
• [@getusha / @aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@robertjchen, @anmurali, @getusha, @aimane-chnaif Eep! 4 days overdue now. Issues have feelings too...

[aimane-chnaif]

We can skip BZ checklist as it's helpDot issue

@anmurali this is ready for payment

[melvin-bot]

@robertjchen, @anmurali, @getusha, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[robertjchen]

I think we're just awaiting payment on this one.

[anmurali]

All done.