[SMARTSCAN] [HOLD for payment 2023-09-27] [$500] HIGH: Receipt modal closes when API response updates image url

[luacmartins]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Request money via Scan option
2. Tap the report preview
3. Tap the request preview
4. Tap the receipt image
5. Verify that the modal opens
6. Wait for a bit and notice that the modal closes

Video:
#26815 (comment)

Expected Result:

Modal should remain open

Actual Result:

Modal closes when API response updates the image URL

Workaround:

Reopen the modal

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019f02e5a5c44adaa8
• Upwork Job ID: 1701050065977769984
• Last Price Increase: 2023-09-11
• Automatic offers:
• tienifr | Contributor | 26663318

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bernhardoj]

When the API response updates the image source, the old (local) source will be considered deleted. If it's deleted, we will dismiss the attachment modal.

App/src/components/Attachments/AttachmentCarousel/index.js

Lines 46 to 49 in 1eafc7d

	// Dismiss the modal when deleting an attachment during its display in preview.
	if (initialPage === -1 && _.find(attachments, (a) => a.source === source)) {
	Navigation.dismissModal();
	} else {

There is a previous discussion about this behavior here but there is no action taken yet.

[allroundexperts]

I think we can also just disable the carousel when the image is being uploaded. This can be done by adding enableOnPreview conditionally if the source starts with blob here.

[luacmartins]

Thanks for the link @allroundexperts! It seems like we're treating this as a new feature. So I'll remove the bug label, add new feature, mark it external and bump it to weekly for now.

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019f02e5a5c44adaa8

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Modal closes when API response updates the image URL

What is the root cause of that problem?

In here, we'll dismiss the modal if the source of an image change since we assume that the image was deleted, however it was not true in this case since the image is the same, it's just local source is different from the Expensify source.

What changes do you think we should make in order to solve the problem?

If the source changes, but another unique identifier of the image (for example the transactionID in this case) remains the same, then we don't consider the image as deleted, and avoid this issue.

The user in that case will still see the local image, or will see the Expensify-source image being loaded on top when it's available, depending on our preference.

What alternative solutions did you explore? (Optional)

If we don't want to show the carousel if the image is being uploaded, we can disable enableOnPreview here if we detect that the image is a local one. If we still want to show the carousel if the user is in offline mode, we can check for that as well.

[luacmartins]

Still looking at proposals

[dylanexpensify]

@luacmartins do we think we'll have this completed by Fancy week?

[melvin-bot]

@luacmartins, @bfitzexpensify, @thesahindia, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

Still waiting on #27824

[bfitzexpensify]

Same update, still waiting on #27824

[melvin-bot]

@luacmartins, @bfitzexpensify, @thesahindia, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

Gonna move this to weekly while it's on hold

[bfitzexpensify]

Still on hold for the moment

[luacmartins]

still waiting on #27824

[dylanexpensify]

27824 is merged and deployed! What's next here?

[dylanexpensify]

Actually, confirmed - this bug doesn't exist any longer. @bfitzexpensify feel free to complete the remaining steps!

[bfitzexpensify]

Sweet. We left this open to address a regression from the initial work done here. Payments here are all complete, the BZ checklist was also completed. Now that that's solved, we can close this one out.

[thesahindia]

Hey @bfitzexpensify, can you please comment the payment summary?

[thesahindia]

Bump @bfitzexpensify

[bfitzexpensify]

Sorry, missed your message the other day. Payment summary:

Contributor: @tienifr $500 paid via Upwork
C+: @thesahindia $500 to be paid via manual request

[JmillsExpensify]

$500 payment approved for @thesahindia based on comment above.