[HOLD for payment 2023-09-27] [$500] Workspaces - Auto select member after invite

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Create a WS
2. Go to members and invite some members (about 3 members)
3. Select 1 member
4. Click invite again and search new member
5. Press enter some times (important: about 3-4 times)
6. Click member to invite
7. Click next
8. Click invite, observe some members was selected.

Expected Result:

No select member after invite

Actual Result:

auto select member after invite

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.62-4

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-25.At.20.47.37.mp4

bandicam.2023-09-04.19-29-39-215.mp4

Expensify/Expensify Issue URL:

Issue reported by: @namhihi237

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692971244708429

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011a838c373f60f807
• Upwork Job ID: 1700169777562968064
• Last Price Increase: 2023-09-08
• Automatic offers:
• bernhardoj | Contributor | 26648637
• namhihi237 | Reporter | 26648640

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing enter in the workspace invite message page and select the member in the members' page.

What is the root cause of that problem?

Both workspace members and invite member pages use SelectionList to show the list. SelectionList subscribe to enter key to select/toggle the member selection. When the screen is out of focus, in this case, we go to the invite message page, the keyboard subscription is still active.

App/src/components/SelectionList/BaseSelectionList.js

Lines 287 to 299 in b95c1dd

	/** Selects row when pressing Enter */
	useKeyboardShortcut(CONST.KEYBOARD_SHORTCUTS.ENTER, selectFocusedOption, {
	captureOnInputs: true,
	shouldBubble: () => !flattenedSections.allOptions[focusedIndex],
	isActive: !activeElement,
	});
	/** Calls confirm action when pressing CTRL (CMD) + Enter */
	useKeyboardShortcut(CONST.KEYBOARD_SHORTCUTS.CTRL_ENTER, onConfirm, {
	captureOnInputs: true,
	shouldBubble: () => !flattenedSections.allOptions[focusedIndex],
	isActive: Boolean(onConfirm),
	});

What changes do you think we should make in order to solve the problem?

In OptionsSelector, we already have a fix to unsubscribe the enter listener when the screen is out of focus, so we can apply the same solution.

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 77 to 83 in b95c1dd

	if (prevProps.isFocused !== this.props.isFocused) {
	if (this.props.isFocused) {
	this.subscribeToKeyboardShortcut();
	} else {
	this.unSubscribeFromKeyboardShortcut();
	}
	}

In SelectionList, use useIsFocused hook to get the screen focus state and use it to disable the keyboard listener here:

App/src/components/SelectionList/BaseSelectionList.js

Lines 288 to 292 in b95c1dd

	useKeyboardShortcut(CONST.KEYBOARD_SHORTCUTS.ENTER, selectFocusedOption, {
	captureOnInputs: true,
	shouldBubble: () => !flattenedSections.allOptions[focusedIndex],
	isActive: !activeElement,
	});

isActive: !activeElement && isFocused

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011a838c373f60f807

[melvin-bot]

Triggered auto assignment to @anmurali (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[michaelhaxhiu]

@sobitneupane we have 1 proposal from @bernhardoj above already ☝️ 😄

[melvin-bot]

@michaelhaxhiu, @anmurali, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[sobitneupane]

will review the proposal shortly.

[sobitneupane]

Proposal from @bernhardoj looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @mountiny, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @sobitneupane Please request via NewDot manual requests for the Reviewer role ($500)

[bernhardoj]

PR is ready

cc: @sobitneupane

[melvin-bot]

🎯 ⚡️ Woah @sobitneupane / @bernhardoj, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @bernhardoj got assigned: 2023-09-13 08:28:51 Z
• when the PR got merged: 2023-09-15 10:50:07 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Unsubscribe enter listener when screen is out of focus #27323

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @sobitneupane does not require payment (Eligible for Manual Requests)
• @bernhardoj requires payment offer (Contributor)
• @namhihi237 requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@michaelhaxhiu / @anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

BaseSelectionList was refactored in this PR. It started the use of useKeybaordShortcut hook. But I believe the problem exists prior to the refactoring.

• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://expensify.slack.com/archives/C049HHMV9SM/p1695617530071679

• [@sobitneupane] Determine if we should create a regression test for this bug.

Yes.

• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[sobitneupane]

Regression Test Proposal

1. Open Settings > Workspaces > Select any workspace > Members > Invite
2. Select one user to invite and press Next
3. Press CTRL/CMD+Enter
4. Verify the text input is still focused
5. Press anywhere to blur the text input
6. Press Enter multiple times
7. Go back
8. Verify the selected user does not change

[michaelhaxhiu]

Nice job! Let's pay this now.

• Bug reporter: $250 @namhihi237 (reported aug 25 which is 5 days before the bug bounty price changed to $50)
• Contributor: $750 @bernhardoj (50% bonus)
• C+: $750 @sobitneupane (50% bonus) please request via newdot

[michaelhaxhiu]

@sobitneupane let us know after you request payment please, so I can close this GH :)

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[michaelhaxhiu]

I'm re-assigning this to another BZ as part of my preparation for Sabbatical (starting Friday).

Next steps:

• Wait for @sobitneupane to confirm he requested payment and received it.
• Close this GH

[joekaufmanexpensify]

@sobitneupane tracks these in his end, so no need to leave this one open for now. We just need to issue payment once he requests it!

[sobitneupane]

#26667 (comment)

Requested payment on newDot.

[JmillsExpensify]

$750 payment approved for @sobitneupane based on BZ summary.