[$1000] Desktop - User stucked on notification on the app icon even though there are no unread messages

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log in with your account A
3. Log in with account B on mobile
4. Send a message from mobile to Desktop

Expected Result:

User able to read the message

Actual Result:

User stucked on notification on the app icon even though there are no unread messages

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.60.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

n/a

Expensify/Expensify Issue URL:
Issue reported by: @rafecolton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692904986751459

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c2cb438a23a5f8f3
• Upwork Job ID: 1701792143757332480
• Last Price Increase: 2023-09-27

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[rafecolton]

Note that this has happened before and usually logging out and back in fixes it, but I have been stuck at one notification for weeks at least

[melvin-bot]

@kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kevinksullivan]

FWIW, I've been at 99+ notifications for as long as I can remember, and I never got to the bottom of it.

I'm not sure if that is a proper reproduction, though. Taking to slack thread

[zanyrenney]

Real-life reports of this here: https://github.com/Expensify/Expensify/issues/315115

[melvin-bot]

@kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c2cb438a23a5f8f3

[melvin-bot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

[kevinksullivan]

Moving forward per the linked GH and slack thread

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App shows notification count badge even though there are no unread messages.

What is the root cause of that problem?

We have a logic to count the number of unread messages to update app's badge based on the isUnread check:

App/src/libs/UnreadIndicatorUpdater/index.js

Lines 10 to 13 in a4672a3

	callback: (reportsFromOnyx) => {
	const unreadReports = _.filter(reportsFromOnyx, ReportUtils.isUnread);
	updateUnread(_.size(unreadReports));
	},

However, most of the unread reports may come from the empty reports appeared when another user adds you to a new chat. Those reports would be excluded from LHN. For example, account B added account A to a new chat without sending any message, a DM between A and B would appear on A's LHN but A haven't opened it yet.

What changes do you think we should make in order to solve the problem?

We should exclude unread empty DMs from unread count.

1. Write a new function in ReportUtils to check for empty messages (and refactor where necessary):

function isEmptyReport(report) {
  return !report.lastMessageText && !report.lastMessageTranslationKey;
}

2. Use it as an additional filter for updating the badge count mentioned above:

if (!ReportUtils.isUnread(report)) {
  return false;
}
return !(ReportUtils.isDM(report) && ReportUtils.isEmptyReport(report));

[tienifr]

Actually, for this specific case of @rafecolton, I think it's the same of #25774 and that was closed as expected behavior.

The unread empty DMs mentioned my proposal would appear if you switched to #focus mode. But I still think we should fix this as it's really annoying users because they don't even see the unread reports, but the badge just keeps red.

[rafecolton]

It does not appear in focus mode, I have tried so many times

[rafecolton]

I don't think this is same as the issue you linked, what led you to conclude that it was?

[melvin-bot]

@kevinksullivan @allroundexperts this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[kevinksullivan]

This got Help wanted recently. We're still just waiting on proposals.

[melvin-bot]

@kevinksullivan, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[rafecolton]

Just noting that the app is now stuck at three notifications for. So it has been mysteriously increasing. Still no unread messages that I can see, so no idea how to reproduce.

[kevinksullivan]

Awaiting proposals

[melvin-bot]

@kevinksullivan @allroundexperts this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[allroundexperts]

@kevinksullivan Should we adjust the bounty to get more proposals?

[kevinksullivan]

doubling!

[melvin-bot]

Upwork job price has been updated to $1000

[shubham1206agra]

Can someone post a demo video here?
I am unable to repro this

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

@kevinksullivan @allroundexperts this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @allroundexperts is eligible for the Internal assigner, not assigning anyone new.

[kevinksullivan]

Closing unless we can reproduce