[HOLD for payment 2023-10-02] [$500] Workspace - In Invite new members the "Contacts" caption does not disappear when scrolling

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Prerequisites:
Log in to HT account.
Steps:

1. Open New Expensify app
2. Go to Settings
3. Go to WorkSpace
4. Open or create a WS
5. Go to Members
6. Tap the "Invite" button
7. Scroll up the contact list

Expected Result:

The caption "Contacts" should be above the list of contacts and when scrolling go up and disappear

Actual Result:

The "Contacts" caption remains in place when scrolling through the contact list and is displayed at the top of the contact list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.58-2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6181692_RPReplay_Final1693323937.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010f0f40876a997e8c
• Upwork Job ID: 1696980437682036736
• Last Price Increase: 2023-09-06
• Automatic offers:
• situchan | Reviewer | 26529846
• mkhutornyi | Contributor | 26529849

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On Invite new members page, "Contacts" header is overlapped when scrolling

What is the root cause of that problem?

stickySectionHeadersEnabled prop is set to true as default in SectionList. And in BaseSelectionList, this prop isn't set.
The issue didn't exist before because this page used BaseOptionsList where this prop is set to false

What changes do you think we should make in order to solve the problem?

Solution 1: set stickySectionHeadersEnabled to false to be consistent
Solution 2: if we wanna keep sticky header, set header background color same as page background color

[situchan]

This is not a deploy blocker. This came from #22622 which was deployed to production yesterday.

[luacmartins]

This is reproducible in production, so NAB. Removing the label.

[situchan]

@mkhutornyi's proposal looks good. I think we should disable iOS sticky behavior in SelectionList to be consistent with OptionsList.

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[situchan]

@hayata-suenaga for future issues, adding External label will do everything needed for external job. i.e. Help Wanted will be added automatically and auto-assign C+.
It seems C+ not auto assigned yet. I can take this if you agree.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010f0f40876a997e8c

[melvin-bot]

Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

[itvalentin19]

How can get new members list?

[melvin-bot]

📣 @itvalentin19! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @mkhutornyi got assigned: 2023-09-06 16:34:49 Z
• when the PR got merged: 2023-09-22 09:21:36 UTC
• days elapsed: 11

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Disable sticky header on selection list #26934

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter — Applause team, so no payment
• Contributor that fixed the issue — @mkhutornyi paid $750 ($500 + 50% bonus) and contract ended
• Contributor+ that helped on the issue and/or PR — @situchan paid $750 ($500 + 50% bonus) and contract ended

For reference, here are some details about the assignees on this issue:

• @mkhutornyi requires payment offer (Contributor)
• @situchan requires payment offer (Reviewer)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mkhutornyi]

This is eligible for bonus as delay was just from merge freeze

[CortneyOfstad]

@hayata-suenaga can you confirm if that qualifies for the bonus?

[CortneyOfstad]

@hayata-suenaga bump on the above — thanks!

[hayata-suenaga]

ops sorry I missed this 😓

@mkhutornyi can you provide the summary of dates so that we can check?

[mkhutornyi]

Assign: Sep 6 10:34 AM CST
PR approval: Sep 7 3:04 PM CST

[CortneyOfstad]

@mkhutornyi @situchan sent you both offers in Upwork for the bonus amount. Please let me know once you accept and I can get those paid. Thanks for your patience with this!

[CortneyOfstad]

Both payments have been made! @situchan where are we at with the checklist above? Thanks!

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: refactor: SelectionList multiple selection #22622
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/22622/files#r1348750497
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No need regression test as this is super minor UI bug and not affect users.

[CortneyOfstad]

Perfect! Thanks @situchan! Closing this!