[HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] [$500] [mWeb] - Chat - Context menu doesn't close after user goes to the previous page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open a chat
2. Send a message
3. Reply in thread of the message sent
4. Hold on the last sent message inside the thread
5. Click on the back button

Expected Result:

The context menu should close after user goes back to the previous page

Actual Result:

The context menu remains open after user goes back to the previous page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.58-1

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230829_113536_Chrome.mp4

Screen.Recording.20230829.140012.Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Nathan-Mulugeta

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693298251936699

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b3a9d92fe2b1c968
• Upwork Job ID: 1701151842381410304
• Last Price Increase: 2023-09-11
• Automatic offers:
• tienifr | Contributor | 26629317
• Nathan-Mulugeta | Reporter | 26629320
• aimane-chnaif | Contributor | 26629407

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[uafrontender]

Same issue as #25598

[Nathan-Mulugeta]

I don't think it is the same issue, this is found only on staging which means it has been introduced yesterday when the new release was pushed.

[luacmartins]

@youssef-lr what's the latest here?

[youssef-lr]

I think this might be the offending PR #24515 cc @allroundexperts

[alitoshmatov]

I think you meant @allroundexperts

[youssef-lr]

Yup sorry!

[aimane-chnaif]

I don't think so as this is deploy blocker. #24515 was deployed to production.

[luacmartins]

Seems to be a regression from #26045. Reverting that PR fixes this particular issue.

[allroundexperts]

@luacmartins #26045 actually fixes 3-4 regressions from this PR.

[luacmartins]

Actually, I'm not sure anymore. I can't seem to reproduce the issue on main again.

[luacmartins]

Anyway, I think this is small enough to be demoted to NAB.

[maddylewis]

humm, i don't believe im able to repro this one either now.

[tienifr]

@Pujan92 Thanks for pointing that out, I'll raise the PR soon

[aimane-chnaif]

I am not able to reproduce on latest main

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @tienifr got assigned: 2023-09-12 11:06:51 Z
• when the PR got merged: 2023-09-20 08:44:35 UTC
• days elapsed: 5

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: 26178 Context menu does not close after user goes to the previous page #27268
• [CP Staging] revert: "fix: 26178 Context menu does not close after user goes to the previous page" #27798

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @aimane-chnaif requires payment offer (Contributor)
• @tienifr requires payment offer (Contributor)
• @Nathan-Mulugeta requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] revert: "fix: 26178 Context menu does not close after user goes to the previous page" #27798

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @aimane-chnaif requires payment offer (Contributor)
• @tienifr requires payment offer (Contributor)
• @Nathan-Mulugeta requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@youssef-lr, @maddylewis, @aimane-chnaif, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[maddylewis]

Payments:

• Reporting bonus: @Nathan-Mulugeta ($250 via Upwork / pre-payment adjustment)
• Contributor: @tienifr ($500 via Upwork)
• C+: @aimane-chnaif ($500 via Upwork)

[maddylewis]

@aimane-chnaif - will you review this checklist when you have a chance? thanks #26178 (comment)

[Nathan-Mulugeta]

Hey @maddylewis this GH was created on Aug 29, thus prior to the bounty decrease announcement. The right amount for reporting bonus should be $250 not $50. Thanks :)

[aimane-chnaif]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR: N/A
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Send any message on any chat A
2. Switch to another chat B
3. Click browser back button to go back to A
4. On A, hover message and click delete icon
5. Verify that delete confirmation popover shows
6. Click browser forward button to go forward to B
7. Verify that delete confirmation popover disappears

[maddylewis]

updated reporting payment for @Nathan-Mulugeta - everyone is paid / closing