[HOLD #301281] [$1000] Web - Missing Default Merchant Statement in Split Bill Details

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click on the plus sign and select "Split Bill."
2. Enter the desired numbers and add an email address.
3. Click on "See More" and observe the not-updated default statement
4. Open the split bill details and click on "See More" again.
5. Notice that the default merchant statement is not present.

Expected Result:

The default merchant statement should be present both in the split bill details and when splitting the bill.

Actual Result:

The default merchant statement is present when splitting the bill but is not displayed in the split bill details.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.57-2

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

girma.mp4

Recording.1316.mp4

Expensify/Expensify Issue URL:

Issue reported by: @tewodrosGirmaA

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692855560586859

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015da00ce15854b03b
• Upwork Job ID: 1694858757030412288
• Last Price Increase: 2023-09-13

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[alphaboss1104]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Missing Default Merchant Statement in Split Bill Details

What is the root cause of that problem?

We displayed the merchant statement of split bill details here:

App/src/components/MoneyRequestConfirmationList.js

Lines 399 to 407 in b38181a

	<MenuItemWithTopDescription
	shouldShowRightIcon={!props.isReadOnly && isTypeRequest}
	title={props.iouMerchant}
	description={translate('common.merchant')}
	style={[styles.moneyRequestMenuItem, styles.mb2]}
	titleStyle={styles.flex1}
	onPress={() => Navigation.navigate(ROUTES.getMoneyRequestMerchantRoute(props.iouType, props.reportID))}
	disabled={didConfirm || props.isReadOnly || !isTypeRequest}
	/>

But we didn't passed the props.iouMerchant from the parent.

App/src/pages/iou/SplitBillDetailsPage.js

Lines 85 to 97 in b38181a

	{Boolean(participants.length) && (
	<MoneyRequestConfirmationList
	hasMultipleParticipants
	payeePersonalDetails={payeePersonalDetails}
	selectedParticipants={participantsExcludingPayee}
	iouAmount={splitAmount}
	iouComment={splitComment}
	iouCurrencyCode={splitCurrency}
	iouType={CONST.IOU.MONEY_REQUEST_TYPE.SPLIT}
	isReadOnly
	shouldShowFooter={false}
	/>
	)}

This is the root cause of this issue.

What changes do you think we should make in order to solve the problem?

First of all we should get the merchant statement of split bill details here:

const {amount: splitAmount, currency: splitCurrency, comment: splitComment, merchant: splitMerchant} = ReportUtils.getTransactionDetails(transaction);

and then We should add iouMerchant as a prop to MoneyRequestConfirmationList component here:

                  <MoneyRequestConfirmationList
                      hasMultipleParticipants
                      payeePersonalDetails={payeePersonalDetails}
                      selectedParticipants={participantsExcludingPayee}
                      iouAmount={splitAmount}
                      iouComment={splitComment}
+                     iouMerchant={splitMerchant}
                      iouCurrencyCode={splitCurrency}
                      iouType={CONST.IOU.MONEY_REQUEST_TYPE.SPLIT}
                      isReadOnly
                      shouldShowFooter={false}
                  />

What alternative solutions did you explore? (Optional)

[pecanoro]

Trying to figure out from which PR is coming

[pecanoro]

@mountiny @luacmartins This deploy blocker is coming from this PR #25794

[luacmartins]

I don't think this is a blocker. It's a really small issue and we're still making several changes to this flow.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015da00ce15854b03b

[melvin-bot]

Current assignee @muttmuure is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[melvin-bot]

@pecanoro, @muttmuure, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[pecanoro]

@situchan Could you review the proposals when you have a chance? Thank you!

[melvin-bot]

@pecanoro, @muttmuure, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[pecanoro]

Before split: Request
After split: Bill split with xxx, xxx

@mountiny @luacmartins Is this expected? I know we are still refactoring some of this stuff so I am not sure if it's expected or not.

[mountiny]

I would probably wait with the split bill after the conference, I dont think this was properly scoped in terms of how the merchant and fields should behave for split so this should be brought to slack first

[pecanoro]

Gotcha! Going to put a HOLD then and move it to weekly

[pecanoro]

Bringing the discussion to Slack

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@pecanoro @muttmuure @situchan this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[pecanoro]

HOLDING on this: https://github.com/Expensify/Expensify/issues/301281

[pecanoro]

Still HOLDING

[pecanoro]

Still HOLDING