[HOLD for payment 2023-08-28] Web -Changed the request to ETB NaN" is shown when When saving with out chaging the amount

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Request money from User A
2. Go to the money request report page
3. Click on The amount to edit
4. Without editing click on Save

Expected Result:

A Massage like "changed the request to ETB NaN (previously ETB 100.00)" should not appear

Actual Result:

A message like "changed the request to ETB NaN (previously ETB 100.00)" appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.55-0

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

T114.Nan-1.mp4

Expensify/Expensify Issue URL:

Issue reported by: @daveSeife

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692241546609289

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

PR will be CPed soon

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

NaN shown when amount modified

What is the root cause of that problem?

PR #24175 introduced the function

App/src/libs/CurrencyUtils.js

Lines 85 to 87 in 0bdf183

	function convertToBackendAmount(amountAsFloat) {
	return Math.round(amountAsFloat * 100);
	}

in place of

function convertToSmallestUnit(currency, amountAsFloat) {
    const currencyUnit = getCurrencyUnit(currency);
    // We round off the number to resolve floating-point precision issues.
    return Math.round(amountAsFloat * currencyUnit);
}

The new function takes only amountAsFloat as argument but the old function had two arguments.
In the same PR when the amount is changed to new function, the currency argument was not removed here

App/src/pages/EditRequestPage.js

Line 109 in 0bdf183

const amount = CurrencyUtils.convertToBackendAmount(transactionCurrency, Number.parseFloat(transactionChanges));

What changes do you think we should make in order to solve the problem?

Change that line in EditRequestPage to

const amount = CurrencyUtils.convertToBackendAmount(Number.parseFloat(transactionChanges));

What alternative solutions did you explore? (Optional)

Result

Screen.Recording.2023-08-17.at.6.39.17.PM.mov

[mountiny]

@jliexpensify we only need to pay the reported here

[jliexpensify]

Payment summary

• Reporter: @daveSeife

Upworks job

[jliexpensify]

@daveSeife are you Dawit S.? If so, can you please update your GH profile to reflect the same name as in Upworks? Cheers.

[daveSeife]

@daveSeife are you Dawit S.? If so, can you please update your GH profile to reflect the same name as in Upworks? Cheers.

@jliexpensify Yes, I am Dawit S. Sure I will.

[jliexpensify]

Thanks, have invited you @daveSeife !

[daveSeife]

@jliexpensify Accepted the Offer. Thank You.

[jliexpensify]

Paid and job closed!

@mountiny - feel free to close this GH once the PR is all sorted.

[mountiny]

I think we can close as there are other issues linked to it

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.55-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP staging] Followup/23961 edit request #24565

If no regressions arise, payment will be issued on 2023-08-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @daveSeife requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mountiny] Determine if we should create a regression test for this bug.
• [@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: