Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$500] [HOLD for payment 2023-11-09] [TS migration] Migrate 'withPolicy.js' HOC to TypeScript #24965

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 24 comments
Closed

[$500] [HOLD for payment 2023-11-09] [TS migration] Migrate 'withPolicy.js' HOC to TypeScript #24965

melvin-bot bot opened this issue Aug 16, 2023 · 24 comments
Assignees
@joelbettner @laurenreidexpensify
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023 •
edited
Loading

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/workspace/withPolicy.js 11
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d99f83209d2384dc
  • Upwork Job ID: 1722306955667914752
  • Last Price Increase: 2023-11-08
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Sep 11, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

@melvin-bot melvin-bot bot added the Overdue label Oct 13, 2023
@blazejkustra blazejkustra mentioned this issue Oct 13, 2023
Merged
59 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 Overdue labels Oct 25, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Oct 31, 2023

Triggered auto assignment to @joelbettner, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@Ollyws
Copy link
Contributor

Ollyws commented Oct 31, 2023

Could you assign me on this one for payment? Thanks.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 2, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'withPolicy.js' HOC to TypeScript [HOLD for payment 2023-11-09] [TS migration] Migrate 'withPolicy.js' HOC to TypeScript Nov 2, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 2, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 2, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 2, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.94-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Nov 8, 2023
@roryabraham roryabraham moved this from Todo to In Progress in Typescript migration Nov 8, 2023
@joelbettner joelbettner added the External Added to denote the issue can be worked on by a contributor label Nov 8, 2023
@melvin-bot melvin-bot bot removed the Overdue label Nov 8, 2023
@joelbettner joelbettner added Overdue AutoAssignerTriage Auto assign issues for triage to an available triage team member and removed External Added to denote the issue can be worked on by a contributor labels Nov 8, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 8, 2023

@joelbettner the AutoAssignerTriage label has been deprecated. Please use Bug for issue triage. See https://stackoverflowteams.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Nov 8, 2023
@joelbettner
Copy link
Contributor

I'm not able to make payments. I'm trying to figure out how to auto assign this issue to someone who can...

@melvin-bot melvin-bot bot removed the Overdue label Nov 8, 2023
@joelbettner joelbettner added the Bug Something is broken. Auto assigns a BugZero manager. label Nov 8, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 8, 2023

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 8, 2023 •
edited by joelbettner
Loading

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

NONE OF THIS APPLIES^. I ONLY ADDED THE BUG LABEL TO GET SOMEONE ASSIGNED TO THE ISSUE THAT COULD MAKE THE PAYMENT.

@joelbettner joelbettner removed the Bug Something is broken. Auto assigns a BugZero manager. label Nov 8, 2023
@joelbettner
Copy link
Contributor

@laurenreidexpensify Not sure if it was the way we are supposed to go about it, but I added the Bug label so this could be paid.

@parasharrajat parasharrajat removed their assignment Nov 8, 2023
@laurenreidexpensify
Copy link
Contributor

@joelbettner sure thang, can you just outline for me who did what on this issue - thanks

@laurenreidexpensify
Copy link
Contributor

bump @joelbettner

@Ollyws
Copy link
Contributor

Ollyws commented Nov 10, 2023

Just $250 for my PR review, the contributor was from SWM so that's handled by them I think. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Nov 13, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 13, 2023

@joelbettner, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

1 similar comment
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 13, 2023

@joelbettner, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 13, 2023

@joelbettner, @laurenreidexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@joelbettner
Copy link
Contributor

joelbettner commented Nov 13, 2023 •
edited
Loading

@laurenreidexpensify

@blazejkustra wrote the PR.
@Ollyws and @fabioh8010 and @BartoszGrajdek reviewed the PR.
@Ollyws did the reviewer checklist for the PR.

@melvin-bot melvin-bot bot removed the Overdue label Nov 13, 2023
@laurenreidexpensify
Copy link
Contributor

checking internally on something here https://expensify.slack.com/archives/C01SKUP7QR0/p1699970605690079

@laurenreidexpensify
Copy link
Contributor

Payment Summary:

  • @blazejkustra - wrote PR - expert contributor, payment N/A
  • @Ollyws - PR Review - $250 payment in Upwork, please accept offer
  • @fabioh8010 - PR Review - expert contributor, payment N/A
  • @BartoszGrajdek - PR Review - expert contributor, payment N/A

@Ollyws
Copy link
Contributor

Ollyws commented Nov 14, 2023

Accepted, thanks!

@laurenreidexpensify
Copy link
Contributor

Payment Summary:

  • @Ollyws - PR Review - $250 payment issued in Upwork

@github-project-automation github-project-automation bot moved this from In Progress to Done in Typescript migration Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joelbettner joelbettner

@laurenreidexpensify laurenreidexpensify

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors Task Typescript Migration
Projects
No open projects
Typescript migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Ollyws @joelbettner @parasharrajat @blazejkustra @laurenreidexpensify