Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [TS migration] Migrate 'withToggleVisibilityView.js' HOC to TypeScript #24959

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 14 comments
Closed
Assignees
Labels
External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/withToggleVisibilityView.js 5
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b725081772425166
  • Upwork Job ID: 1722541508579926016
  • Last Price Increase: 2023-11-09
  • Automatic offers:
    • Ollyws | Contributor | 27589854
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@BartoszGrajdek
Copy link
Contributor

Hey! I’m Bartosz from Software Mansion, an expert agency, and I’d like to work on this issue!

Copy link
Author

melvin-bot bot commented Nov 3, 2023

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@thienlnam
Copy link
Contributor

PR currently on staging, and so we should be good once this hits prod!

@roryabraham roryabraham moved this from Todo to In Progress in Typescript migration Nov 8, 2023
@Ollyws
Copy link
Contributor

Ollyws commented Nov 9, 2023

Can I get assigned to this one for payment? Thanks!

@thienlnam thienlnam added the External Added to denote the issue can be worked on by a contributor label Nov 9, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'withToggleVisibilityView.js' HOC to TypeScript [$500] [TS migration] Migrate 'withToggleVisibilityView.js' HOC to TypeScript Nov 9, 2023
Copy link
Author

melvin-bot bot commented Nov 9, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01b725081772425166

@thienlnam thienlnam added the NewFeature Something to build that is a new item. label Nov 9, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 9, 2023
Copy link
Author

melvin-bot bot commented Nov 9, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

Copy link
Author

melvin-bot bot commented Nov 9, 2023

@thienlnam thienlnam removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 9, 2023
@melvin-bot melvin-bot bot added Daily KSv2 and removed Daily KSv2 Weekly KSv2 labels Nov 9, 2023
@thienlnam thienlnam changed the title [$500] [TS migration] Migrate 'withToggleVisibilityView.js' HOC to TypeScript [$250] [TS migration] Migrate 'withToggleVisibilityView.js' HOC to TypeScript Nov 9, 2023
Copy link
Author

melvin-bot bot commented Nov 9, 2023

Upwork job price has been updated to $250

Copy link
Author

melvin-bot bot commented Nov 9, 2023

📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@thienlnam
Copy link
Contributor

thienlnam commented Nov 9, 2023

This is ready to be paid out - C+ review for TS PR cc @greg-schroeder

@ghost

This comment was marked as outdated.

@melvin-bot melvin-bot bot added the Monthly KSv2 label Nov 9, 2023
@greg-schroeder
Copy link
Contributor

Okay doing the thing! Sorry I missed this cause I filter payments by the issue title having "waiting for payment" in it

@greg-schroeder
Copy link
Contributor

Paid.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Typescript migration Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

5 participants