[TS migration] Migrate 'withNavigationFallback.js' HOC to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/components/withNavigationFallback.js	4

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[melvin-bot]

Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove 'withNavigationFallback.js' HOC #29449

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[VickyStash]

This ticket will require one more PR, because the first one was reverted due to regression. But I need to do additional updates as it was discussed here.

[VickyStash]

During further investigations, it turned out this HOC is not possible to remove because ErrorBoundary is located outside of the NavigationContainer an has a fallback component GenericErrorPage which has Buttons inside. So without this HOC usage it'll crash.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mallenexpensify]

@akinwale can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~010e0e878e726013b5

[mallenexpensify]

@akinwale , @ntdiary are there two PRs for this issue? I see both below that appear to link back here

• Remove 'withNavigationFallback.js' HOC #29449
• [No QA] [TS migration] Migrate 'withNavigationFallback.js' HOC to TypeScript #30072

[akinwale]

@akinwale can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~010e0e878e726013b5

Accepted. Thanks.

[akinwale]

@akinwale , @ntdiary are there two PRs for this issue? I see both below that appear to link back here

• Remove 'withNavigationFallback.js' HOC #29449
• [No QA] [TS migration] Migrate 'withNavigationFallback.js' HOC to TypeScript #30072

Yes. There was a regression in #29449 which resulted in a revert, and then a second review.

[ntdiary]

@akinwale , @ntdiary are there two PRs for this issue? I see both below that appear to link back here

• Remove 'withNavigationFallback.js' HOC #29449
• [No QA] [TS migration] Migrate 'withNavigationFallback.js' HOC to TypeScript #30072

Yes. There was a regression in #29449 which resulted in a revert, and then a second review.

@mallenexpensify, yeah, a bit strange, the first PR was reverted, and then, seemingly due to no explicit assignee, the second PR was automatically assigned to me, and then I reviewed it. It appears that the melvin-bot is not working as expected. 😂

[mallenexpensify]

Thanks @ntdiary , for issue below, should pay have been half since there was a regression @akinwale ? (I paid you already but can request a refund for half if so).

• Remove 'withNavigationFallback.js' HOC #29449

@ntdiary if you reviewed the second PR, you're due compensation, right?

[akinwale]

Thanks @ntdiary , for issue below, should pay have been half since there was a regression @akinwale ? (I paid you already but can request a refund for half if so).

• Remove 'withNavigationFallback.js' HOC #29449

I believe so? I'm not sure if TS migrations are treated differently.

[techievivek]

Not overdue, finishing up the payments. Gentle bump @mallenexpensify

[slafortune]

@mallenexpensify it looks like you've already done some of this payment but don't see it linked here anywhere -

(I paid you already but can request a refund for half if so).

@ntdiary if you reviewed the second PR, you're due compensation, right?

Do you want to assign this to yourself @mallenexpensify or is there something I can do to finish this up?

[ntdiary]

@ntdiary if you reviewed the second PR, you're due compensation, right?

Sorry for the delayed response. I think so, but I'm not sure how much the payment is in this case. I'm happy to accept it regardless. 😄

[mallenexpensify]

https://www.upwork.com/jobs/~010e0e878e726013b5
Checking on the 50% cuz for TS migrations here https://expensify.slack.com/archives/C01SKUP7QR0/p1702085217213809

[melvin-bot]

@slafortune, @VickyStash, @techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

[techievivek]

Not overdue, finalizing the payment.

[slafortune]

@ntdiary - offer sent - https://www.upwork.com/nx/wm/offer/100026606

[mallenexpensify]

$125 refund requested from @akinwale ,
@akinwale , please confirm once you've accepted, thx
https://www.upwork.com/jobs/~010e0e878e726013b5

[akinwale]

$125 refund requested from @akinwale , @akinwale , please confirm once you've accepted, thx https://www.upwork.com/jobs/~010e0e878e726013b5

Done.

[ntdiary]

@ntdiary - offer sent - https://www.upwork.com/nx/wm/offer/100026606

@slafortune, thank you! Have accepted. :)

[techievivek]

Not overdue, @mallenexpensify are we done with the payment here? Can we close this out then?

[ntdiary]

@techievivek, the payment has been made to me. 😄

[techievivek]

Okkkiiee, great, thanks for confirming. 🙇