[HOLD for payment 2023-08-28] Web - Request money - "Select a currency" tooltip is shown even if user is unable to do so

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Send a money request from account A to account B
2. Click on the IOU preview component to open the IOU report
3. Click on the currency to edit it
4. Hover over the currency

Expected Result:

Since user is unable to change currency tooltip saying "Select a currency" should not be shown

Actual Result:

"Select a currency" tooltip is shown even if user is unable to do so

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.54-7

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

-26156794439242399052023-08-14_23_01_46.MP4

Recording.1196.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Nathan-Mulugeta

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692043293482609

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b0a3053455828bfb
• Upwork Job ID: 1691413101275987968
• Last Price Increase: 2023-08-15

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[laurenreidexpensify]

Just a heads up I am working 50% today and have just finished for the day, if there's anything that needs to be done on this from my side please ask in bug-zero Slakc thanks

[Gonals]

On it!

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Select a currency" tooltip is shown even if user is unable to do so

What is the root cause of that problem?

We are wrapping the pressable in a Tooltip, regardless of whether disabled is true or not:

App/src/components/CurrencySymbolButton.js

Lines 25 to 38 in 56f0b0f

	function CurrencySymbolButton({onCurrencyButtonPress, currencySymbol, disabled}) {
	const {translate} = useLocalize();
	return (
	<Tooltip text={translate('iOUCurrencySelection.selectCurrency')}>
	<PressableWithoutFeedback
	onPress={onCurrencyButtonPress}
	accessibilityLabel={translate('iOUCurrencySelection.selectCurrency')}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON}
	disabled={disabled}
	>
	<Text style={styles.iouAmountText}>{currencySymbol}</Text>
	</PressableWithoutFeedback>
	</Tooltip>
	);

What changes do you think we should make in order to solve the problem?

If disabled is true, we should return the PressableWithoutFeedback without wrapping it in the Tooltip component.

Alternatively, a slightly more elegant way would be to change text={translate('iOUCurrencySelection.selectCurrency')} to:
text={!disabled && translate('iOUCurrencySelection.selectCurrency')}

If text is omitted, only the children are rendered:

App/src/components/Tooltip/tooltipPropTypes.js

Line 6 in 56f0b0f

/** The text to display in the tooltip. If text is ommitted, only children will be rendered. */

What alternative solutions did you explore? (Optional)

N/A

[BhuvaneshPatil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tooltip displays for currency when it's disabled

What is the root cause of that problem?

We don't have any check while displaying tooltip for currency.

App/src/components/CurrencySymbolButton.js

Lines 28 to 37 in 4275741

	<Tooltip text={translate('iOUCurrencySelection.selectCurrency')}>
	<PressableWithoutFeedback
	onPress={onCurrencyButtonPress}
	accessibilityLabel={translate('iOUCurrencySelection.selectCurrency')}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON}
	disabled={disabled}
	>
	<Text style={styles.iouAmountText}>{currencySymbol}</Text>
	</PressableWithoutFeedback>
	</Tooltip>

What changes do you think we should make in order to solve the problem?

There are few ways to handle this.

• Display different message in tooltip when it's disabled, eg - Can't change the currency

• Pass null as text when it's disabled. It hides the tooltip.
  js
  text={disabled ? null : translate('iOUCurrencySelection.selectCurrency')}

• We can modify CurrencySymbolButton to not render Tooltip component depending on value of prop disabled

    if (disabled) {
        return (
            <PressableWithoutFeedback
                onPress={onCurrencyButtonPress}
                accessibilityLabel={translate('iOUCurrencySelection.selectCurrency')}
                accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON}
                disabled={disabled}
            >
                <Text style={styles.iouAmountText}>{currencySymbol}</Text>
            </PressableWithoutFeedback>
        );
    }

• We can modify Tooltip component to disable showing content by adding new prop - disabled

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b0a3053455828bfb

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @fedirjh (Internal)

[Gonals]

Marking this as internal, as I already have a fix in place and it is a deploy blocker

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.55-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Do not show currency tooltip when we can't change it #24576

If no regressions arise, payment will be issued on 2023-08-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Nathan-Mulugeta requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Gonals] The PR that introduced the bug has been identified. Link to the PR:
  This wasn't really a regression, just something introduced with the functionality itself
• [@Gonals] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  I think we can skip this. This wasn't really a regression, just something introduced with the functionality itself
• [@Gonals] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  I think we can skip this. This wasn't really a regression, just something introduced with the functionality itself
• [@Gonals] Determine if we should create a regression test for this bug.
  Nope
• [@Gonals] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[laurenreidexpensify]

Payment Summary:

bug reporter @Nathan-Mulugeta $250 - offer sent in Upwork
issue fix @Gonals $0 - Expensify internal
review @mountiny $0 - Expensify intenral

[Nathan-Mulugeta]

Bump @laurenreidexpensify for payment to be processed.

[melvin-bot]

@Gonals, @laurenreidexpensify Huh... This is 4 days overdue. Who can take care of this?

[Gonals]

Filled checklist. This wasn't really a regression, just something introduced with the functionality itself, I'd say, so all good.

[laurenreidexpensify]

Payment issued 👍 Closing