Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create TS Types for themes #24118

Closed
grgia opened this issue Aug 3, 2023 · 6 comments
Closed

Create TS Types for themes #24118

grgia opened this issue Aug 3, 2023 · 6 comments
Assignees
@chrispader @grgia
Labels
Monthly KSv2 Not a priority Reviewing Has a PR in review

Comments

@grgia
Copy link
Contributor

grgia commented Aug 3, 2023

Let's create a Color type to ensure that all colors used are from our brand colors.
Let's also create a Theme type to ensure that both themes are the same shape.
@grgia grgia converted this from a draft issue Aug 3, 2023
@grgia grgia self-assigned this Aug 3, 2023
@grgia
Copy link
Contributor Author

grgia commented Aug 3, 2023

@chrispader

@grgia grgia added the Weekly KSv2 label Aug 3, 2023
@chrispader chrispader mentioned this issue Aug 5, 2023
Merged
59 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Aug 5, 2023
@chrispader
Copy link
Contributor

@grgia Working on it here: #24178

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Aug 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

This issue has not been updated in over 15 days. @grgia eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@chrispader
Copy link
Contributor

Still on HOLD for #22986

@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2023

@chrispader, @grgia, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Oct 26, 2023
@chrispader
Copy link
Contributor

THe PR that fixes this should be ready! 👍
cc @grgia

@grgia grgia moved this from Merged to Done - Live ✅ in Theme Switching / Light Mode Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrispader chrispader

@grgia grgia

Labels
Monthly KSv2 Not a priority Reviewing Has a PR in review
Projects
No open projects
Theme Switching / Light Mode
Status: Done - Live ✅
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrispader @grgia