[HOLD for payment 2023-08-24] [$1000] Workspace - The border radius of the workspace icon and the overlay are not the same

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Prerequisite: have more than 4 workspaces (at least one with custom image)

1. Open www.staging.new.expensify.com
   page
2. Open settings
3. Take a look at the workspaces (the one with custom image)

Expected Result:

Workspaces visually should look the same

Actual Result:

Workspace with custom image has an extra empty space next to the image

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome
• MacOS / Desktop

Version Number: 1.3.49.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0186b5853447bf36a7
• Upwork Job ID: 1686843318689447936
• Last Price Increase: 2023-08-02

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[bondydaa]

hmm I suspect #23707 cc @bernhardoj @danieldoglas @thesahindia

[bondydaa]

able to reproduce on main

going to revert #23707 locally and see if it fixes it.

[bondydaa]

yep that fixes it

[bondydaa]

I don't think we need to revert the PR though. This is pretty minor IMO and only really shows itself if you have multiple workspaces and a custom image uploaded AND that workspace is not the first one in the row

[bondydaa]

thread here discussing this https://expensify.slack.com/archives/C01GTK53T8Q/p1691008185925749

but I think we can remove blocker and let this go through external bug process.

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0186b5853447bf36a7

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[situchan]

As this was found within regression period, @bernhardoj would be fixing this.

[huzaifa-99]

As this was found within regression period, @bernhardoj would be fixing this.

Makes sense, thanks.

[bondydaa]

ah yeah sorry whoops I wasn't fully aware of the correct process for these types of regressions. updating the labels and linking it to the OG issue so they can fix it.

[saalimzafar]

Anyone here who can help me to join the slack channel? for contribution purpose?
I sent the emails but so far no response.

[bernhardoj]

@bondydaa @situchan Thanks for tagging. Looking into this

[danieldoglas]

This issue should not have a payment linked to it since it's connected to #23426

[joekaufmanexpensify]

Yep, makes sense. @abdulrahuman5196 I'm going to remove you from this one, since you didn't review the PR to fix the regression.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.54-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix custom workspace avatar border radius is different #24088

If no regressions arise, payment will be issued on 2023-08-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@bondydaa] The PR that introduced the bug has been identified. Link to the PR: N/A
• [@bondydaa] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@bondydaa] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@bernhardoj] Determine if we should create a regression test for this bug.
• [@bernhardoj] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[joekaufmanexpensify]

Since this was fixing a regression, I don't think any payment is due to @bernhardoj or @thesahindia . And there was no reporter here, which means no payment overall.

[joekaufmanexpensify]

@bernhardoj / @bondydaa could you complete the checklist here when you have a sec? TY!

[bernhardoj]

@joekaufmanexpensify I don't think we need to complete the checklist for this issue as this is actually part of #23426, so we only need to do the checklist there.

[joekaufmanexpensify]

Cool, thanks! Since there's no payment/BZ checklist needed for this issue, going to close this one, as it's all set. Thanks everyone!