[HOLD for payment 2023-08-08] Split bill - App crashed when delete split bill

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch App
2. Create split bill
3. Long press on request
4. Tap on 'Delete request"

Expected Result:

The request should be delete.

Actual Result:

App crashed when delete split bill.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.47-3
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6145295_RPReplay_Final1690569314.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcaaron]

Seems related -> https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues/e8357e4aff4d3d4b1bf39478a981997d?time=last-seven-days&versions=1.3.45-8%20(1001034508);1.3.46-0%20(1001034600);1.3.46-1%20(1001034601)&sessionEventKey=64C1D1B6003700015C31403A37B96EE1_1838760527596780186

[Beamanator]

May be related to: https://github.com/Expensify/Expensify/issues/304096

[mountiny]

cc @luacmartins I am not sure if we have tested this flow well

[Beamanator]

I'm seeing this in web when I try to delete a split:

[Beamanator]

@mountiny can you find the PR that may have caused this?

[mountiny]

#19095

I dont think we should revert though, I think we should just disable the option on split action before we figure this out

[Beamanator]

Ok can you take over finding a good solution for this one? 🙏

[Beamanator]

Idk why melvin thought this should be weekly lol

[situchan]

App/src/libs/actions/IOU.js

Line 775 in 8cdb506

const iouReport = allReports[`${ONYXKEYS.COLLECTION.REPORT}${reportAction.originalMessage.IOUReportID}`];

The crash happens on this line because originalMessage.IOUReportID doesn't exist in split report action
Based on https://github.com/Expensify/App/pull/19095/files#diff-16a590a45460a9abf1e402441b50e3cb2659ee3da203ca30a2fa4ce3f9411957L253-R253, I think the issue existed before #19095. And enabling delete money request feature just revealed this.

[mountiny]

correct, I think we just forgot about this case.

[mountiny]

@Beamanator thats an automation for when PR is raised and marked as ready for a review.

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Disallow deleting split actions #23916

If no regressions arise, payment will be issued on 2023-08-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mountiny] Determine if we should create a regression test for this bug.
• [@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

$1000 to @Ollyws for internal review

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.48-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Disallow deleting split actions #23916

If no regressions arise, payment will be issued on 2023-08-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

$1000 for @Ollyws for internal review.

[Ollyws]

Is the BZ checklist required for a temporary fix like this?

[greg-schroeder]

Offer sent to @Ollyws

[greg-schroeder]

Don't think the checklist will be super necessary here personally. Going to close this now that offer is sent! will pay as soon as accepted

[Ollyws]

@greg-schroeder Friendly bump for payment.

[greg-schroeder]

Oh, wow, sorry, sending now @Ollyws

[tranvantoan-qn]

@mountiny I apologize for bringing up this matter once more.

Did we solely disable the "Delete" option on the main Request?

I'm still experiencing the same crash, but in a slightly different manner.

Whenever a split request is initiated, it also generates a sub-report for each participant, allowing me to delete each request. Unfortunately, this leads to a crash when in Offline mode.

TypeError: Cannot read properties of null (reading 'reportID')
    at main-426150f61736a9bd57d7.bundle.js:1:3040782
    at vendors-3db7fcdc0b1c4dcfe55f.bundle.js:1:16283362
    at Xt (vendors-3db7fcdc0b1c4dcfe55f.bundle.js:1:16282859)
    at Function.qt (vendors-3db7fcdc0b1c4dcfe55f.bundle.js:1:16283340)
    at Object.P (main-426150f61736a9bd57d7.bundle.js:1:3040751)
    at Object.m (main-426150f61736a9bd57d7.bundle.js:1:1269288)
    at jn (main-426150f61736a9bd57d7.bundle.js:1:1470777)
    at fA (vendors-3db7fcdc0b1c4dcfe55f.bundle.js:1:9865482)
    at Bs (vendors-3db7fcdc0b1c4dcfe55f.bundle.js:1:9922584)
    at bl (vendors-3db7fcdc0b1c4dcfe55f.bundle.js:1:9911745)