Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task - 'Share somewhere' subtitle appears a few seconds after user display name #23583

Closed
3 of 6 tasks
kbecciv opened this issue Jul 25, 2023 · 17 comments
Closed
3 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Jul 25, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Tap + icon > Assign task > Enter title > Next.
  3. Select an assignee.
  4. Select User B that User A has never interacted with.

Expected Result:

'Share somewhere' subtitle appears together with the user display name.

Actual Result:

'Share somewhere' subtitle appears a few seconds after user display name.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.45.3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6141378_Screen_Recording_20230726_014036_Chrome.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jul 25, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 25, 2023

Current assignee @thienlnam is eligible for the Engineering assigner, not assigning anyone new.

@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jul 25, 2023
@marcaaron
Copy link
Contributor

@thienlnam is this one not a blocker?

@thienlnam
Copy link
Contributor

Nope, definitely not a blocker - I've been meaning to find the linked PR but I believe this is also from a new feature we recently added

@thienlnam
Copy link
Contributor

thienlnam commented Jul 25, 2023

cc @chiragxarora and @eVoloshchak
@bondydaa

@chiragxarora
Copy link
Contributor

I'm unable to reproduce this but I've caught other bugs which look unrelated to my PR.
Can somebody tell me what exactly is meant by Select User B that User A has never interacted with

@chiragxarora
Copy link
Contributor

@eVoloshchak are you able to reproduce this?

@chiragxarora
Copy link
Contributor

chiragxarora commented Jul 26, 2023

Screen.Recording.2023-07-26.at.2.07.01.PM.mov

see the above video,
what I caught is when we create a new chat with random email not logged in (which I think is meant by never interacted before email) and assign it a task, share somewhere modal also picks it and what it uses is optimistic data (see the accountID in first case) and thus it does not have participants field in the report object.

But when we assign it to ourself and select the share destination separately, we get two instances of same user (see two [email protected] in which one with subtitle uses optimistic data and the other one without subtitle uses real accountID). We are unable to select the optimistic one but we are able to select the other one, and when we select the real accountID one, we get subtitle this time.
Notice the anomaly that for same email, earlier it didn't show subtitle when we directly assigned the task to it, but when we assigned to someone else and picked our target email to share separately, it showed subtitle because in this case it wasn't using optimistic data unlike before.
I don't think this is a regression from my PR but its the other underlying issues

  1. getting a mix of optimistic and real reports
  2. unable to select optimistic one
  3. optimistic ones not have participants array in report object.

and some of these were also caught by @eVoloshchak during the review which we discussed
cc @bondydaa @eVoloshchak

@thienlnam
Copy link
Contributor

Thanks for investigating - yeah I think since you have to assign someone you haven't talked to before this would also be fixed from this internal issue https://github.com/Expensify/Expensify/issues/294203. Going to put this on hold and just address it there

@thienlnam thienlnam added Weekly KSv2 and removed Daily KSv2 labels Jul 26, 2023
@thienlnam thienlnam changed the title Task - 'Share somewhere' subtitle appears a few seconds after user display name [HOLD 294203]Task - 'Share somewhere' subtitle appears a few seconds after user display name Jul 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 3, 2023
@thienlnam
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Aug 4, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 14, 2023
@thienlnam thienlnam changed the title [HOLD 294203]Task - 'Share somewhere' subtitle appears a few seconds after user display name Task - 'Share somewhere' subtitle appears a few seconds after user display name Aug 24, 2023
@thienlnam thienlnam added the Bug Something is broken. Auto assigns a BugZero manager. label Aug 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2023

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 24, 2023
@melvin-bot

This comment was marked as outdated.

@melvin-bot melvin-bot bot removed the Overdue label Aug 24, 2023
@thienlnam
Copy link
Contributor

Holding PR is merged, can we see if this is still reproducible / and if not let's close it

@johncschuster
Copy link
Contributor

@kbecciv can you please try reproducing the behavior to see if it persists?

@kbecciv
Copy link
Author

kbecciv commented Aug 26, 2023

Hello @johncschuster! Coming back from vacation, let me check if the issue is reproducible in latest build.

@kbecciv
Copy link
Author

kbecciv commented Aug 26, 2023

Unable to reproduce it on build v1.3.57-5

Recording.4030.mp4

@melvin-bot melvin-bot bot added the Overdue label Aug 28, 2023
@thienlnam
Copy link
Contributor

Awesome, applause report so closing it out now!

@melvin-bot melvin-bot bot removed the Overdue label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

7 participants