-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web - The sign in with apple button is not highlighted when hover over #23353
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @flodnv ( |
The Apple sign-in PR was reverted here so this won't happen now and can be closed. Anyway, we will need to handle it once the Apple sign-in gets reimplemented. @shawnborton what should the hover style look like here? Should there be a border on hover like we show for some avatars? Or can we just ignore showing any hover styles? |
I think we can just ignore hover styles for now. |
This issue has not been updated in over 15 days. @Nikhil-Vats eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
@Nikhil-Vats the apple sign in with 'apple' and 'google' button is now appearing on the front page with no hover over styles. shouldn't this issue be fixed now? |
@Nikhil-Vats, this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
The sign in with apple button should be highlighted
Actual Result:
he sign in with apple button is not highlighted
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.43-6
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
new.BR.45.mp4
Expensify/Expensify Issue URL:
Issue reported by: @Yokabdk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689895328247729
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: