Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - The sign in with apple button is not highlighted when hover over #23353

Closed
1 of 6 tasks
kbecciv opened this issue Jul 21, 2023 · 7 comments
Closed
1 of 6 tasks

Web - The sign in with apple button is not highlighted when hover over #23353

kbecciv opened this issue Jul 21, 2023 · 7 comments

Comments

@kbecciv
Copy link

kbecciv commented Jul 21, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com web
  2. Observe the first page or 'Get started below' page
  3. Hover over the cursor on the sign in with apple button

Expected Result:

The sign in with apple button should be highlighted

Actual Result:

he sign in with apple button is not highlighted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.43-6
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

new.BR.45.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Yokabdk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689895328247729

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jul 21, 2023
@kbecciv kbecciv changed the title Web - he sign in with apple button is not highlighted when hover over Web - The sign in with apple button is not highlighted when hover over Jul 21, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 21, 2023

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Nikhil-Vats
Copy link
Contributor

The Apple sign-in PR was reverted here so this won't happen now and can be closed.

Anyway, we will need to handle it once the Apple sign-in gets reimplemented. @shawnborton what should the hover style look like here? Should there be a border on hover like we show for some avatars? Or can we just ignore showing any hover styles?

cc @marcochavezf @lindboe

@flodnv flodnv added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jul 21, 2023
@flodnv flodnv assigned Nikhil-Vats and unassigned flodnv Jul 21, 2023
@shawnborton
Copy link
Contributor

I think we can just ignore hover styles for now.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Aug 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

This issue has not been updated in over 15 days. @Nikhil-Vats eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@Yokabdk
Copy link

Yokabdk commented Aug 30, 2023

@Nikhil-Vats the apple sign in with 'apple' and 'google' button is now appearing on the front page with no hover over styles. shouldn't this issue be fixed now?

Copy link

melvin-bot bot commented Nov 2, 2023

@Nikhil-Vats, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants