[HOLD for payment 2023-07-28] Web - On click of back button user redirects to Paypal page instead of setting page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to Paypal page using link https://staging.new.expensify.com/settings/payments/add-paypal-me
2. Add or edit username and click on save button
3. Click back button from Payments page

Expected Result:

User should be redirect to setting

Actual Result:

User redirects to Paypal page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.42-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.3723.mp4

Screen.Recording.2023-07-18.at.11.36.24.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689660420182909

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a8d252f6439d653a
• Upwork Job ID: 1681299351721226240
• Last Price Increase: 2023-07-18

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

on click of back button user redirects to Paypal page instead of setting page

What is the root cause of that problem?

We call navigate back function with fallbackRoute as setting route but we don't pass shouldEnforceFallback as true which makes this condition false because we already have a page in stack and then we navigate back to the previous page which is paypal page

App/src/libs/Navigation/Navigation.js

Line 117 in ffe659e

if (shouldEnforceFallback || (!getActiveRouteIndex(navigationRef.current.getState()) && fallbackRoute)) {

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Line 403 in ffe659e

onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS)}

What changes do you think we should make in order to solve the problem?

We can add shouldEnforceFallbackc as true when we call Navigate.goBack function here to go back the fallbackRoute with replacing the previous page

Navigation.goBack(ROUTES.SETTINGS, true)

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Line 403 in ffe659e

onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS)}

What alternative solutions did you explore? (Optional)

We also can call Navigation.navigate here instead of Navigation.goBack

Navigation.navigate(ROUTES.SETTINGS)

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Line 403 in ffe659e

onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS)}

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a8d252f6439d653a

[adamgrzybowski]

Commenting

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @narefyev91 (Internal)

[mountiny]

@dukenv0307 Apologies, this one was already resolved in the slack thread from SWM

[dukenv0307]

@mountiny No problem.

[bondydaa]

merged the PR, not sure why automation didn't pick it up 🤷 threw the reviewing label on manually

[bondydaa]

just waiting for deploy to prod

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.43-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [navigation-refactor] Change navigate to goBack after saving on paypal me page #23086

If no regressions arise, payment will be issued on 2023-07-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @adamgrzybowski does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@bondydaa] The PR that introduced the bug has been identified. Link to the PR:
• [@bondydaa] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@bondydaa] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91 / @adamgrzybowski] Determine if we should create a regression test for this bug.
• [@narefyev91 / @adamgrzybowski] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[muttmuure]

I don't think this one requires payment?

[gadhiyamanan]

i think this is eligible for reporting bonus

[melvin-bot]

@bondydaa, @narefyev91, @muttmuure, @adamgrzybowski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[bondydaa]

waiting for @muttmuure to issue payment

[muttmuure]

Invited @gadhiyamanan to the upwork job

[gadhiyamanan]

@muttmuure applied, thanks!

[muttmuure]

Offer sent

[gadhiyamanan]

@muttmuure offer accepted, thanks!

[muttmuure]

Paid