Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-08-24] Implement a basic list for waypoints and the Add stop button #22700

Closed
neil-marcellini opened this issue Jul 11, 2023 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@neil-marcellini
Copy link
Contributor

Please follow the plan in the design doc.

@melvin-bot
Copy link

melvin-bot bot commented Jul 17, 2023

Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2023
@neil-marcellini neil-marcellini self-assigned this Jul 17, 2023
@neil-marcellini
Copy link
Contributor Author

On HOLD, changing to a weekly while I wait.

@melvin-bot melvin-bot bot removed the Overdue label Jul 18, 2023
@neil-marcellini neil-marcellini added Weekly KSv2 and removed Daily KSv2 labels Jul 18, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 26, 2023
@neil-marcellini
Copy link
Contributor Author

On hold

@neil-marcellini
Copy link
Contributor Author

I got started on the PR.

@neil-marcellini
Copy link
Contributor Author

Taking this off hold and making it a daily, because I'm working on it daily and it's only on HOLD for deployment.

@neil-marcellini neil-marcellini changed the title [HOLD 22698] Implement a basic list for waypoints and the Add stop button Implement a basic list for waypoints and the Add stop button Aug 2, 2023
@neil-marcellini neil-marcellini added Daily KSv2 and removed Weekly KSv2 labels Aug 2, 2023
@neil-marcellini
Copy link
Contributor Author

I made a lot of progress on this today and I think I finished the implementation. I'll work on putting it up for review next time.

@neil-marcellini
Copy link
Contributor Author

On Friday I made some tweaks to the scrollable list so that waypoints would fade off the bottom properly when they are different sizes. That took a while. Today I think I can get it up for review.

@melvin-bot melvin-bot bot removed the Overdue label Aug 7, 2023
@neil-marcellini
Copy link
Contributor Author

I spent most of today struggling with running NewDot on the various platforms. It's been a while since I've used anything other than web, and most of the platforms do not work for me right now.

As soon as I get videos on Android, Android Chrome, and desktop I can put the PR up for review.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 8, 2023
@neil-marcellini neil-marcellini added Daily KSv2 and removed Weekly KSv2 labels Aug 9, 2023
@Santhosh-Sellavel
Copy link
Collaborator

@neil-marcellini / @thienlnam Assign me this & also add a BZ when you get a chance thanks!

@thienlnam thienlnam added the Bug Something is broken. Auto assigns a BugZero manager. label Aug 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 11, 2023

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot

This comment was marked as off-topic.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Aug 17, 2023
@melvin-bot melvin-bot bot changed the title Implement a basic list for waypoints and the Add stop button [HOLD for payment 2023-08-24] Implement a basic list for waypoints and the Add stop button Aug 17, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.54-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot

This comment was marked as off-topic.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 23, 2023
@Santhosh-Sellavel
Copy link
Collaborator

@NicMendonca We can skip the checklist as this is a feature, can you leave a payment summary, thanks!

@NicMendonca
Copy link
Contributor

@Santhosh-Sellavel thank you!

@Santhosh-Sellavel
Copy link
Collaborator

Requested on ND

@JmillsExpensify
Copy link

Reviewed the details for @Santhosh-Sellavel. $1,000 approved for payment in NewDot based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants