[HOLD for payment 2023-07-21] [HOLD for payment 2023-07-20] New Task - Crash when choosing Assignee as phone number

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Click on + icon
3. Select Assign task option
4. Enter the title and description of the data > Next
5. Select Assignee as number phone
6. Enter title and click on next button
7. Click on Confirm task button

Expected Result:

App doesn't crash

Actual Result:

Crash when choosing Assignee as phone number (Web)
In IOS appears Hmm... its not here
You don't have access to this chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.39.5

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6124129_Recording__2800.mp4

Bug6124129_ios_1107_crash.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[francoisl]

I can't reproduce the issue on staging nor dev. I wonder if it's a backend issue with the account you were using specifically. Any chance you can share the email address of the account you were using so I can check backend logs please?

[francoisl]

Internal logs of a crash for this here.

NewExpensify crash caught by error boundary - Cannot read property 'avatar' of undefined ~~ errorInfo: '{"componentStack":" in TaskView in WithCurrentUserPersonalDetails(TaskView) in Unknown in withOnyx(Component) in Unknown in Unknown in Unknown in ReportActionItem in withOnyx(Component) in Unknown in Unknown in Unknown in Unknown in Unknown

The stacktrace is pointing to reading a .avatar in TaskView... @jasperhuangg any chance this could be on this line?

[francoisl]

I was able to reproduce the crash, the key is that you have to create a task with a phone number you've never interacted with before. I think the issue is the line I pointed to before, working on a fix.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.39-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Safely get avatar URL for task #22765

If no regressions arise, payment will be issued on 2023-07-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[francoisl]

The fix is done and was handled internally. Co-assigning @s77rt and BZ so we remember to complete payment for the PR review.

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[s77rt]

• The PR that introduced the bug has been identified: Implement Task Detailed View Redesign #20841
• The offending PR has been commented on: Implement Task Detailed View Redesign #20841 (comment)
• A discussion in #expensify-bugs has been started: The bug could have been caught during testing, I don't feel a discussion is required here.
• Determine if we should create a regression test for this bug: No

[francoisl]

Not sure why this got auto-labelled both Monthly and Daily, but it's ready for payment now @anmurali.

[anmurali]

To confirm this was fixed by @jasperhuangg and @s77rt and @fedirjh are owed $1,000 each for PR review?

[s77rt]

@anmurali This was fixed by @francoisl. @jasperhuangg and I reviewed the PR. I think I'm the only one pending payment here. I don't see where @fedirjh tag came from 😅

[francoisl]

Anu is OOO at the moment, I'm going to reapply the label to assign another BugZero member.

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[francoisl]

Uuuh looks like I accidentally "unassigned all" instead of just unassigning Anu. Sorry @slafortune, going to reassign to you to handle payments please 🙇

[slafortune]

@s77rt offer sent - https://www.upwork.com/nx/wm/offer/25911954

[s77rt]

@slafortune Accepted! Thanks!

[slafortune]

Paid