[HOLD for payment 2023-07-28] Payment method not sticky in the expenseReport view.

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

policyExpenseChat beta to have access to the workspace chats.

1. As the member, create a request for $50.00 > send it to a workspace
2. As the admin of the workspace change the settlement method from Pay with Expensify to Pay elsewhere
3. Pay the report
4. As the member, create another request for $50.00 > send it to the same workspace
5. As the admin of the workspace, navigate to the member's workspace chat
6. Observe the pay button in the report preview displays Pay elsewhere ✅
7. Click on the report preview to navigate to the expense report
8. Observe the pay button in the header displays Pay with Expensify ❌

Expected Result:

The Pay elsewhere settlement method should have been displayed in the expenseReport view as it's "sticky" and it was the last settlement method used by the admin.

Actual Result:

The pay button in the expenseReport header incorrectly displayed as Pay with Expensify

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.38-4
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

WQPWKegZCi.mp4

Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C02HWMSMZEC/p1688744493384329?thread_ts=1688476481.516029&cid=C02HWMSMZEC

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0156192fdb8e16398b
• Upwork Job ID: 1678491715975114752
• Last Price Increase: 2023-07-10

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0156192fdb8e16398b

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @fedirjh (Internal)

[trjExpensify]

@mountiny you're jumping on this one right?

[mountiny]

Yep, had problems with local vm yesterday. Will aim to make a pr today

[mountiny]

PR with fix is in a review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.43-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Make sure the IOU or expense level settlement button defaults to last used method #22846

If no regressions arise, payment will be issued on 2023-07-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[fedirjh]

BugZero Checklist:

• Link to the PR: Add pay button to money request header #18692
• Link to comment: N/A. This doesn’t look like a regression. It's more of a feature request.
• Link to discussion: N/A
• Determine if we should create a regression test for this bug: ✅

Regression Test Proposal

1. As UserB set up a PayPal address.
2. As UserB, request money from UserA.
3. As UserA, navigate to the IOU report and choose to settle with PayPal.
4. Pay the report.
5. Create a new request as UserB, requesting money from UserA.
6. As UserA, navigate to this new IOU report
7. Verify that the settlement button defaults to PayPal.
8. Change the payment type to Pay elsewhere.
9. Pay the report.
10. Create a new request as UserB, requesting money from UserA.
11. As UserA, navigate to this new IOU report
12. Verify that the default method shown is Pay elsewhere.

Do we agree 👍 or 👎

[mountiny]

@trjExpensify Thanks Fedi, I think we should add this testcase

[trjExpensify]

Nice! @mountiny, this bug was for expenseReports on a workspace, so I think we should add both.

Sticky Payment Method

IOUs

1. As UserB set up a PayPal address.
2. As UserB, request money from UserA.
3. As UserA, navigate to the IOU report and choose to Pay with PayPal.me
4. Pay the report.
5. Create a new request as UserB, requesting money from UserA.
6. As UserA, navigate to this new IOU report
7. Verify that the settlement button defaults to PayPal.
8. Change the payment type to Pay elsewhere.
9. Pay the report.
10. Create a new request as UserB, requesting money from UserA.
11. As UserA, navigate to this new IOU report
12. Verify that the default method shown is Pay elsewhere.

Expense Reports

1. As the member, create a request for $50.00 > send it to a workspace
2. As the admin of the workspace change the settlement method from Pay with Expensify to Pay elsewhere
3. Pay the report
4. As the member, create another request for $50.00 > send it to the same workspace
5. As the admin of the workspace, navigate to the member's workspace chat
6. Verify the pay button in the report preview displays Pay elsewhere
7. Click on the report preview to navigate to the expense report
8. Verify the pay button in the header displays Pay elsewhere

[trjExpensify]

@fedirjh sent you an offer! 👍

[trjExpensify]

QA issue created, paid @fedirjh for the C+ review. Closing!